Make sponsor button less annoying - #1173
Conversation
📝 WalkthroughWalkthroughTwo unrelated fixes: the ChangesMigration Idempotency Guards
Sponsor Button UI Change
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/js/components/app-header.tsx`:
- Line 61: The HeartIcon component uses a hard-coded color class text-pink-600
and is missing a size class for consistency with other icons in the header.
Replace the text-pink-600 class with a semantic token (such as text-sponsor)
that should be defined in your theme configuration, and add the size-4 class to
the HeartIcon to match the sizing of the WifiIcon and WifiOffIcon components
above it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 9cd9a54b-cdd2-4657-833e-5eab49e48174
📒 Files selected for processing (2)
database/migrations/2026_01_09_170832_add_name_to_cron_jobs_table.phpresources/js/components/app-header.tsx
| onClick={() => window.open('https://github.com/sponsors/saeedvaziry')} | ||
| aria-label="Sponsor" | ||
| > | ||
| <HeartIcon className="text-pink-600" /> |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Use a semantic token instead of hard-coded colour; add size class for consistency.
The HeartIcon uses text-pink-600, which violates the guideline to avoid hard-coded colours. Additionally, the icon lacks a size class, whilst the WifiIcon and WifiOffIcon above use size-4.
Consider defining a custom semantic token (e.g., text-sponsor) in your theme for the sponsor heart, or use an existing semantic colour. Also add size-4 to match the sizing of other icons in this header.
♻️ Proposed fix
- <HeartIcon className="text-pink-600" />
+ <HeartIcon className="size-4 text-pink-600" />Then update your theme configuration to define a semantic token for sponsor/heart colour and replace text-pink-600 with that token.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@resources/js/components/app-header.tsx` at line 61, The HeartIcon component
uses a hard-coded color class text-pink-600 and is missing a size class for
consistency with other icons in the header. Replace the text-pink-600 class with
a semantic token (such as text-sponsor) that should be defined in your theme
configuration, and add the size-4 class to the HeartIcon to match the sizing of
the WifiIcon and WifiOffIcon components above it.
Source: Coding guidelines
Summary by CodeRabbit
New Features
Chores