Repository navigation
Migrate validators to ValidatorFX - #9
Merged
Merged
Conversation
vladcheck
enabled auto-merge (squash)
October 5, 2026 14:14
vladcheck
disabled auto-merge
October 6, 2026 08:01
vladcheck
force-pushed
the
vladcheck/validator-refactor
branch
from
October 6, 2026 08:01
f55c22c to
fec3c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
String isValid(...)заменена наnet.synedra.validatorfx.Validator+Check: каждый валидатор отдаётvalidate()(чистая проверка),check()иcreateCheck()для привязки к полям формы.LoginFormControllerвалидирует форму однимvalidator.validate(), ошибки рисуются черезFieldErrorDecorationв существующих лейблах и гаснут при вводе (immediateClear). СвоиValidator/AbstractValidatorудалены — конфликтовали по имени с классом библиотеки..mvn/jvm.configс--sun-misc-unsafe-memory-access=allow. Убирает JEP 498-предупреждения от Lombok (lombok.permit.Permit) и Spotless (ModuleHelper) на JDK 24+. Сам Lombok оставлен: апстрим чинить предупреждение отказался, удаление зависимости не вариант.Проверки
mvn clean verify: 25 тестов зелёные, Spotless и Checkstyle без нарушений.Известно
В тестах осталось безвредное предупреждение JavaFX
classes were loaded from 'unnamed module'— убрать его можно только переводом тестов на module-path (проверено: работает, но тянет ~25 строк конфига и--add-opensдля Monocle), поэтому сознательно оставлено.