Repository navigation
Fix bids from a new bidder not taking the money - #3602
Merged
Merged
Conversation
Since 57932d8, the bid branch of HandleAuctionPlaceBid no longer takes the bid from a player who isn't already the highest bidder, while the previous bidder still gets his bid back by mail.
Contributor
|
Oops, accidentally deleted this line. 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Since 57932d8,
HandleAuctionPlaceBidno longer takes the money for a bid from a player who isn't already the highest bidder. TheLogModifyMoney(-int32(packet.price), ...)call was removed from the bid branch together with the oldSendAuctionOutbiddedMailcall, so only the buyout branch still charges a new bidder. The previous bidder still gets his bid back by mail, which means every outbid creates money.This adds the call back in the bid branch. The cmangos commit that 57932d8 is based on still takes the money there (
AuctionEntry::UpdateBid).Proof
Issues
How2Test
Todo / Checklist