Skip to content

Fix bids from a new bidder not taking the money - #3602

Merged
ratkosrb merged 1 commit into
vmangos:developmentfrom
ornfelt:fix-auction-bid-money
Nov 18, 2026
Merged

ratkosrb merged 1 commit into
vmangos:developmentfrom
ornfelt:fix-auction-bid-money

Conversation

@ornfelt

@ornfelt ornfelt commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

🍰 Pullrequest

Since 57932d8, HandleAuctionPlaceBid no longer takes the money for a bid from a player who isn't already the highest bidder. The LogModifyMoney(-int32(packet.price), ...) call was removed from the bid branch together with the old SendAuctionOutbiddedMail call, so only the buyout branch still charges a new bidder. The previous bidder still gets his bid back by mail, which means every outbid creates money.

This adds the call back in the bid branch. The cmangos commit that 57932d8 is based on still takes the money there (AuctionEntry::UpdateBid).

Proof

Issues

  • None

How2Test

  • Put an item on the auction house with a starting bid and no buyout.
  • Bid on it with a second character: before, its money doesn't change; after, the bid is taken.
  • Outbid it with a third character: the second character gets its bid back by mail, the third one pays its bid.

Todo / Checklist

  • None

Since 57932d8, the bid branch of HandleAuctionPlaceBid no longer takes
the bid from a player who isn't already the highest bidder, while the
previous bidder still gets his bid back by mail.
@ratkosrb

Copy link
Copy Markdown
Contributor

Oops, accidentally deleted this line. 🙈

@ratkosrb
ratkosrb merged commit d9e767a into vmangos:development Nov 18, 2026
13 checks passed
Stoabrogga pushed a commit to Stoabrogga/vmangos that referenced this pull request Nov 18, 2026
Since 57932d8, the bid branch of HandleAuctionPlaceBid no longer takes
the bid from a player who isn't already the highest bidder, while the
previous bidder still gets his bid back by mail.

(cherry picked from commit d9e767a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants