Repository navigation
Fix compilation with OpenSSL 4.0+ where OPENSSL_atexit was removed - #3606
Merged
ratkosrb merged 1 commit intoNov 19, 2026
Merged
Conversation
zaidrain06
added a commit
to zaidrain06/zaidrain06
that referenced
this pull request
Nov 19, 2026
Stoabrogga
pushed a commit
to Stoabrogga/vmangos
that referenced
this pull request
Nov 21, 2026
Co-authored-by: Said Yagmur <zaidrain06@users.noreply.github.com> (cherry picked from commit 32c5ce8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Fixes compilation failure on systems shipping OpenSSL 4.0+ (e.g. Arch Linux with OpenSSL 4.1.0), where
OPENSSL_atexitand automaticatexit(OPENSSL_cleanup)registration were removed upstream (OpenSSL PR#29385).OPENSSL_VERSION_MAJOR < 4), continues usingOPENSSL_atexit(UnloadLegacyProvider)so the legacy provider is unloaded insideOPENSSL_cleanup()while the default library context still exists.OPENSSL_VERSION_MAJOR >= 4), registersUnloadLegacyProviderviastd::atexit(UnloadLegacyProvider).Proof
OPENSSL_atexit: Atexit.final draft.cleanup openssl/openssl#29385Issues
How2Test
src/shared/Crypto/InitializeCrypto.cppagainst OpenSSL 3.x (OPENSSL_VERSION_MAJOR == 3) and OpenSSL 4.x (OPENSSL_VERSION_MAJOR >= 4).mangosd/realmdstartup runsCrypto::InitializeCryptoAndPrintVersion()and passesCryptoSelfCheck().Todo / Checklist