Skip to content

Remove perspective divide for orthographic frustum #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertosfield merged 2 commits into from
Aug 12, 2026
+14 −4
Merged

Remove perspective divide for orthographic frustum #1728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d779322
Remove perspective divide for orthographic frustum
rolandhill Jul 10, 2026
07c96c4
Restructured the orthographic and perspective handling into if else b…
robertosfield Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions include/vsg/vk/State.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,20 @@ namespace vsg
value_type f = -proj[1][1];
value_type sc = f * std::sqrt(square(mv[0][0]) + square(mv[1][0]) + square(mv[2][0]) + square(mv[0][1]) + square(mv[1][1]) + square(mv[2][1])) * 0.5;
value_type inv_scale = value_type(1.0) / sc;
lodScale.set(mv[0][2] * inv_scale,
mv[1][2] * inv_scale,
mv[2][2] * inv_scale,
mv[3][2] * inv_scale);

if (proj[2][3] == value_type(0.0))
{
// For an orthographic projection the projected size of a bounding sphere is independent of
// its distance from the eye (proj[2][3] == 0: there is no perspective divide).
lodScale.set(value_type(0.0), value_type(0.0), value_type(0.0), inv_scale);
}
else
{
lodScale.set(mv[0][2] * inv_scale,
mv[1][2] * inv_scale,
mv[2][2] * inv_scale,
mv[3][2] * inv_scale);
}
}

template<typename T>
Expand Down
Loading