Skip to content

fix layer offset calculation when uploading cubemaps with MipmapLayout - #1730

Merged
robertosfield merged 1 commit into
vsg-dev:masterfrom
KAlO2:fix/skybox
Aug 12, 2026
Merged

fix layer offset calculation when uploading cubemaps with MipmapLayout#1730
robertosfield merged 1 commit into
vsg-dev:masterfrom
KAlO2:fix/skybox

Conversation

@KAlO2

@KAlO2 KAlO2 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

Fixed per-layer buffer offsets when uploading images with MipmapLayout.

This fixes issue #1721

vsgExamples/vsgskybox.cpp renders skybox with incorrect faces.
skybox bug

So I used RenderDoc to capture frames and inspect the SkyBox textures. I found that when switching between the ±X/Y/Z faces, the displayed image content remained unchanged — in other words, all six faces were using the same texture. I traced the issue to an incorrect offset calculation in TransferTask.cpp.
vsg skybox bug

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test vsgExamples/vsgskybox.cpp

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robertosfield
robertosfield merged commit dec7a9a into vsg-dev:master Aug 12, 2026
5 checks passed
@KAlO2
KAlO2 deleted the fix/skybox branch August 13, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants