docs: document Vim indent and dedent operators in the code editor - #439
docs: document Vim indent and dedent operators in the code editor#439hongyi-chen wants to merge 2 commits into
Conversation
The Vim keybindings reference is an exhaustive list of supported functionality, but it omitted the > and < operators. Verified against crates/vim/src/vim.rs. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
|
oh this is neat i didn't know we supported this |
There was a problem hiding this comment.
Overview
This PR updates the Vim keybindings documentation for Warp's code editor to include indent and dedent operators, plus examples for normal and visual mode usage. The added documentation matches the referenced Vim implementation behavior, and there are no security or spec-alignment concerns from the provided context.
Concerns
- None.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Summary
Warp's code editor supports the Vim
>and<indent and dedent operators, but the Vim keybindings reference didn't list them. That page is meant to be an exhaustive list of implemented Vim functionality, so a missing operator reads as "not supported."Found by the
missing_docsdrift-watch audit (changelog item #14268) and verified againstcrates/vim/src/vim.rs.Changes
src/content/docs/code/code-editor/code-editor-vim-keybindings.mdx>,<,>>, and<<to the Editing table.>and<are operators that compose with motions, text objects, and counts, plus their visual-mode behavior.Source verification
All behavior in the new subsection maps to
crates/vim/src/vim.rs:VimOperator::Indent/Dedentare constructed from>/<inPendingAction::fromandVimOperator::from.>>and<<resolve toVimOperand::Lineinhandle_normal_pending_operation.i/ato text objects andj/kto linewise motions for any operator, so>apand>jwork.pending_action_countbefore the operator, so3>>applies a count.handle_visual_nothing_pendinghandles</>viacreate_visual_operatorand then returns to Normal mode.Verification
npm run buildpasses.Deferred findings from this audit run
None specific to this page. Run-wide deferrals are listed in the companion audit-bookkeeping PR.
Conversation: https://staging.warp.dev/conversation/53c4f3f8-39bb-46c1-a5c0-66b467db0439
Run: https://oz.staging.warp.dev/runs/019fb91e-74a0-73f4-ac72-f2d88c32fab5
This PR was generated with Oz.
Co-Authored-By: Oz oz-agent@warp.dev