docs: document auto_approve_bypasses_command_denylist in the settings reference - #444
Closed
hongyi-chen wants to merge 1 commit into
Closed
docs: document auto_approve_bypasses_command_denylist in the settings reference#444hongyi-chen wants to merge 1 commit into
hongyi-chen wants to merge 1 commit into
Conversation
… reference The setting is GA with a Settings toggle, but was missing from the all-settings reference. #424 fixed the prose on the profiles page only. Verified against app/src/settings/ai.rs and app/src/ai/blocklist/permissions.rs. Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Closing as a duplicate of #430, which already adds Found independently by a Co-Authored-By: Oz oz-agent@warp.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents.warp_agent.other.auto_approve_bypasses_command_denylistis a user-facing, GA setting with a toggle in Settings > Agents, but it was missing from the all-settings reference.Found by the
missing_docsdrift-watch audit (new setting detected by the snapshot diff) and verified againstapp/src/settings/ai.rs.Changes
src/content/docs/terminal/settings/all-settings.mdxauto_approve_bypasses_command_denylistto the[agents.warp_agent.other]section, with its type and default, and cross-links to the Run until completion and command denylist sections of the agent profiles page.Relationship to #424
PR #424 corrected the prose about this behavior on
agent-profiles-permissions.mdx. It didn't add the setting to the all-settings reference, which is what the audit checks and what this PR fixes. The two pages now agree.Source verification
app/src/settings/ai.rs:toml_path: "agents.warp_agent.other.auto_approve_bypasses_command_denylist",type: bool,default: true,private: false,surface: SettingSurfaces::ALL.feature_flag, and the toggle is pushed unconditionally inAIInputWidget::render(app/src/settings_view/ai_page.rs), so this is GA.app/src/ai/blocklist/permissions.rs(can_autoexecute_command) confirms the Admin Panel caveat:bypass_user_denylistadditionally requires!AppExecutionMode::is_sandboxed(), and when the bypass applies the code still enforcesget_org_execute_commands_denylist(ctx).Verification
npm run buildpasses.Deferred findings from this audit run
The same audit flagged
agents.voice.voice_input_hold_keyas undocumented. It isSettingSurfaces::TUI(Warp Agent CLI only) and has no desktop-app UI, so it follows the existing convention for CLI-only settings and is mappedinternalin the companion audit-bookkeeping PR rather than documented here. Other run-wide deferrals are listed in that PR.Conversation: https://staging.warp.dev/conversation/53c4f3f8-39bb-46c1-a5c0-66b467db0439
Run: https://oz.staging.warp.dev/runs/019fb91e-74a0-73f4-ac72-f2d88c32fab5
This PR was generated with Oz.
Co-Authored-By: Oz oz-agent@warp.dev