Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 15, 2026
avabbbb
force-pushed
the
fix/global-recording-shortcuts
branch
from
October 18, 2026 14:11
76b26b4 to
e018e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Recordly's recording HUD is capture protected, a remote desktop client may also lose sight of it. This adds a persistent Remote visible mode in Home → Settings → Recording, plus configurable global recording controls so recording can be operated while the HUD is hidden or unfocused.
Remote visible mode disables HUD protection while preserving the user's previous hide-from-recordings preference. The settings explain that the HUD can also appear in the resulting video. Turning the mode off restores the preference; macOS native process exclusions require restarting an active recording.
Default global shortcuts (Command replaces Control on macOS):
The source shortcut restores the HUD and calls its existing source-button handler. It selects only and does not start recording. Repeated input shares the pending picker; selecting is ignored while recording. Windows supports screen/window choices, macOS also supports areas, and Linux retains its list/portal flow. The screenshot/GIF/MP4 quick toolbar remains future work.
Bindings can be edited, disabled, or reset in Settings, persist across restarts, report registration failures, and unregister on quit. Commands target the capture-owning HUD rather than whichever editor window is focused, reuse existing recording callbacks, and respect countdown/finalization. Discard confirmation defaults to keeping the recording and cannot discard a subsequent take. Native cancellation remains busy until cleanup finishes.
Includes a usage and manual acceptance guide and a screenshot:
Validation
52a913569afa0229c5a3c116f0c93b828ededb84(2026-10-14); the fork's main was fast-forwarded to the same commit.npm run typecheckpasses.git diff --checkpasses.npx vite build --config vite.config.tspasses for the renderer, Electron main, and preload, including the existing main CJS smoke guard. This is not a packaged Windows installer build.52a91356produced 1551 passed, the exact same 9 failures, 7 skipped. Failures concern captions/generation, project trash, recording library, and share thumbnails (including Windows symlink permissions and FFmpeg execution issues in this environment). The failure names were compared programmatically.The fork design PR #1 has also been refreshed to upstream main and explicitly makes global capture/control and UU acceptance P0. It remains documentation only.
Remaining validation / related work
Draft: a real Mac → UU Remote → Windows session, OS-level shortcut delivery, capture exclusion/visibility, playable recorded media, and a packaged Windows build remain unverified. Browser tests use mocked native capture and do not establish those outcomes. Native dependency/browser downloads were too slow to complete in this environment; headed tests used installed Chrome instead. No installed application or existing user recording/configuration was replaced.
Related: #693 is a macOS remote-HUD report and is not evidence of every Windows failure. Existing open PR #956 overlaps the global shortcut work; this PR independently includes remote visibility, HUD show/hide, confirmed discard, and the associated acceptance guide. Maintainers may prefer coordinating or splitting the overlapping shortcut changes. No claim that the remote desktop client can always forward a particular combination.