Add a buffer_view variant option to wireframe sample - #568
Merged
Conversation
alan-baker
commented
Jun 23, 2026
alan-baker
commented
Contributor
- Combines all model data into a single buffer
- Beginning of the buffer has model metadata
- vertex and index buffers for each draw set from offsets into the buffer
- buffer_view shaders passed the whole buffer
* Combines all model data into a single buffer
* Beginning of the buffer has model metadata
* vertex and index buffers for each draw set from offsets into the
buffer
* buffer_view shaders passed the whole buffer
Contributor
Author
|
@beaufortfrancois thoughts on this as the buffer_view example we discussed? |
beaufortfrancois
left a comment
beaufortfrancois
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for starting this!
mwyrzykowski
approved these changes
Jun 23, 2026
beaufortfrancois
approved these changes
Jun 23, 2026
alan-baker
marked this pull request as ready for review
June 23, 2026 16:44
beaufortfrancois
approved these changes
Aug 5, 2026
beaufortfrancois
enabled auto-merge (squash)
August 5, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.