Skip to content

feat: embed rustls platform verifier - #8

Merged
seokju-na merged 1 commit into
mainfrom
rustls-embedded
Oct 11, 2026
Merged

seokju-na merged 1 commit into
mainfrom
rustls-embedded

Conversation

@seokju-na

@seokju-na seokju-na commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Summary by cubic

Embeds the rustls platform verifier Android artifact directly into the library so consumers no longer need the GitHub-only Maven repository.

  • Unpacks the upstream AAR during build, merging its manifest and resources into our own and packaging its classes locally.
  • Adds a CI script that verifies the published POM/module metadata contains no org.rustls dependency and that every embedded class, resource, manifest entry, license, and keep rule matches the resolved upstream artifact.
  • Adds the upstream MIT license file to the packaged AAR.
  • Build-time resolution of the upstream artifact still requires the raw GitHub Maven repo, which is now documented as build-time only in settings.gradle.kts.

Written for commit ca696e5. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Build and Packaging
    • The Android library now includes the Rustls platform verifier and its license in the published package, without requiring consumers to fetch a separate Rustls dependency.
    • Publication checks now verify that the package contains the expected verifier classes, resources, manifest settings, and licensing information.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1f52f1c1-a478-440f-ad1d-cff48a9291d9

📥 Commits

Reviewing files that changed from the base of the PR and between c3be231 and ca696e5.


📒 Files selected for processing (5)
  • .github/workflows/ci.yaml
  • lib/build.gradle.kts
  • lib/src/main/resources/META-INF/rustls-platform-verifier-LICENSE-MIT
  • scripts/verify-publication.mjs
  • settings.gradle.kts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The library build now embeds Rustls platform-verifier classes, resources, and manifest data. CI generates Maven publication metadata and checks the assembled Android publication, including its packaged Rustls files and license.

Changes

Rustls publication

Layer / File(s) Summary
Embed Rustls in the library
lib/build.gradle.kts, lib/src/main/resources/META-INF/rustls-platform-verifier-LICENSE-MIT, settings.gradle.kts
Gradle extracts Rustls classes, resources, and manifest data from the AAR and adds them to the library build. The project includes the Rustls MIT license, and a settings comment describes the artifact as build-time-only.
Verify the Android publication
.github/workflows/ci.yaml, scripts/verify-publication.mjs
CI generates the POM and module metadata, then runs checks for published dependencies, manifest entries, ProGuard rules, packaged resources and classes, and the MIT license.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant CIWorkflow
  participant GradleBuild
  participant PublicationMetadata
  participant AndroidAAR
  participant PublicationVerifier
  CIWorkflow->>GradleBuild: Generate publication metadata and build library
  GradleBuild->>PublicationMetadata: Write POM and module metadata
  GradleBuild->>AndroidAAR: Package embedded Rustls files
  CIWorkflow->>PublicationVerifier: Run verification script
  PublicationVerifier->>PublicationMetadata: Check for Rustls dependency
  PublicationVerifier->>AndroidAAR: Check manifest, resources, classes, and license
Loading

Merge Risk: ⚪ Minimal · up to ca696

No new merge-blocking issue was established. The network policy behavior was already present in the published library.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: embedding the Rustls platform verifier into the Android library.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@seokju-na
seokju-na merged commit 413a45e into main Oct 11, 2026
4 checks passed
@seokju-na
seokju-na deleted the rustls-embedded branch October 11, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant