You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Embeds the rustls platform verifier Android artifact directly into the library so consumers no longer need the GitHub-only Maven repository.
Unpacks the upstream AAR during build, merging its manifest and resources into our own and packaging its classes locally.
Adds a CI script that verifies the published POM/module metadata contains no org.rustls dependency and that every embedded class, resource, manifest entry, license, and keep rule matches the resolved upstream artifact.
Adds the upstream MIT license file to the packaged AAR.
Build-time resolution of the upstream artifact still requires the raw GitHub Maven repo, which is now documented as build-time only in settings.gradle.kts.
Written for commit ca696e5. Summary will update on new commits.
Summary by CodeRabbit
Build and Packaging
The Android library now includes the Rustls platform verifier and its license in the published package, without requiring consumers to fetch a separate Rustls dependency.
Publication checks now verify that the package contains the expected verifier classes, resources, manifest settings, and licensing information.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Walkthrough
The library build now embeds Rustls platform-verifier classes, resources, and manifest data. CI generates Maven publication metadata and checks the assembled Android publication, including its packaged Rustls files and license.
Changes
Rustls publication
Layer / File(s)
Summary
Embed Rustls in the library lib/build.gradle.kts, lib/src/main/resources/META-INF/rustls-platform-verifier-LICENSE-MIT, settings.gradle.kts
Gradle extracts Rustls classes, resources, and manifest data from the AAR and adds them to the library build. The project includes the Rustls MIT license, and a settings comment describes the artifact as build-time-only.
Verify the Android publication .github/workflows/ci.yaml, scripts/verify-publication.mjs
CI generates the POM and module metadata, then runs checks for published dependencies, manifest entries, ProGuard rules, packaged resources and classes, and the MIT license.
sequenceDiagram
participant CIWorkflow
participant GradleBuild
participant PublicationMetadata
participant AndroidAAR
participant PublicationVerifier
CIWorkflow->>GradleBuild: Generate publication metadata and build library
GradleBuild->>PublicationMetadata: Write POM and module metadata
GradleBuild->>AndroidAAR: Package embedded Rustls files
CIWorkflow->>PublicationVerifier: Run verification script
PublicationVerifier->>PublicationMetadata: Check for Rustls dependency
PublicationVerifier->>AndroidAAR: Check manifest, resources, classes, and license
Loading
Merge Risk:⚪ Minimal · up to ca696
No new merge-blocking issue was established. The network policy behavior was already present in the published library.
Pre-merge checks | 5
✅ Passed checks (5 passed)
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: embedding the Rustls platform verifier into the Android library.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Embeds the rustls platform verifier Android artifact directly into the library so consumers no longer need the GitHub-only Maven repository.
org.rustlsdependency and that every embedded class, resource, manifest entry, license, and keep rule matches the resolved upstream artifact.settings.gradle.kts.Written for commit ca696e5. Summary will update on new commits.
Summary by CodeRabbit