Skip to content

chore: upgrade ffi 0.3.0 - #9

Merged
seokju-na merged 2 commits into
mainfrom
upgrade-0.3.0
Oct 11, 2026
Merged

seokju-na merged 2 commits into
mainfrom
upgrade-0.3.0

Conversation

@seokju-na

@seokju-na seokju-na commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Summary by cubic

Upgrades the FFI bindings to 0.3.0 and updates the getUpdate documentation to reflect its actual 204/304 no-content behavior.

Written for commit 28d7926. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Release
    • Updated the release version to 0.3.0.
  • Documentation
    • Clarified that an update request may return no result when there is no new content or when the content has not changed.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d44b575-6446-45b3-96a7-7d80b1a56e96

📥 Commits

Reviewing files that changed from the base of the PR and between 413a45e and 28d7926.


📒 Files selected for processing (2)
  • .ffi-version
  • lib/src/main/kotlin/dev/wvb/WvbFFI.kt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The FFI version changed to 0.3.0. The expected UniFFI checksum for Remote.getUpdate changed, and its documentation now identifies HTTP 204 and 304 as reasons for a null result.

Changes

Remote.getUpdate release metadata and documentation

Layer / File(s) Summary
FFI version, checksum, and response documentation
.ffi-version, lib/src/main/kotlin/dev/wvb/WvbFFI.kt
The FFI version changed to 0.3.0, and the expected checksum for Remote.getUpdate changed. Both documentation entries now identify HTTP 204 and 304 as reasons for a null result.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other


Merge Risk: ⚪ Minimal · up to 28d79

The FFI pin and binding checksum match. The native behavior behind the updated 204/304 documentation remains unconfirmed, but no specific merge-blocking failure is established.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: upgrading the FFI dependency to version 0.3.0.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)


  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR




🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread lib/src/main/kotlin/dev/wvb/WvbFFI.kt
@seokju-na
seokju-na merged commit 60e2007 into main Oct 11, 2026
4 checks passed
@seokju-na
seokju-na deleted the upgrade-0.3.0 branch October 11, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant