Repository navigation
test: raise coverage to 84% - #2
Open
juicycleff wants to merge 1 commit into
Open
juicycleff wants to merge 1 commit into
juicycleff wants to merge 1 commit into
Conversation
Coverage goes from 76% to 84% for the root package. Adds tests for ProvideValue, ProvideNamed, the deprecated Provide/Inject wrappers, lifecycle options, InjectGroup and resolveGroup (empty, missing registry, wrong element type), HasType, deriveServiceName, ErrTypeMismatch, DependencyGraph lookups and the Name accessors on Lazy, OptionalLazy and Provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes vessel's test coverage from 76.3% to 84.2%, which clears the 80% bar awesome-go asks for. There are no source changes.
You can check the number yourself:
Everything new is in
provide_gaps_test.go. It covers code that had no tests at all:ProvideValue,ProvideNamed, the deprecatedProvideConstructorandInjectTypewrappers, the lifecycle options,InjectGroupandresolveGroup(empty groups, a missing registry, the wrong element type),HasType,deriveServiceName,ErrTypeMismatch, the dependency graph lookups, and theName()accessors onLazy,OptionalLazyandProvider.Codecov isn't switched on for this repo yet, so CI won't post a coverage figure until it is.