Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #766 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 64 64
Lines 4331 4350 +19
=======================================
+ Hits 4313 4332 +19
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
The dependency bound lacks mandatory tap enforcement, and connection timing and URL mode overrides can leave ASH frames unacknowledged.
2 open findings
What changed in this PR
Requires ESPHome serial proxies to use on-device ASH ACK handling while Bellows retains NAK handling.
Changes:
- Requests ESPHome protocol-tap mode.
- Adds configurable ASH ACK suppression and tests.
- Adds the serialx dependency.
| File | Description |
|---|---|
bellows/uart.py |
Enables ESPHome protocol mode and ACK suppression. |
bellows/ash.py |
Adds optional standalone ACK suppression. |
tests/test_uart.py |
Tests transport-mode selection. |
tests/test_ash.py |
Tests ACK suppression while preserving NAKs. |
pyproject.toml |
Adds serialx dependency. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zigpy-review-bot
added
new feature
11 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESPHome serial proxying now supports
ezsp_proxy_tap, allowing bellows to opt into on-device ASH auto-ACKing and mitigate network latency issues. This is a requirement for serial proxies.Depends on puddly/serialx#138.