Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #768 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 64 64
Lines 4331 4332 +1
=======================================
+ Hits 4313 4314 +1
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrow, preserves configured table bounds, and includes tests for sequential allocation and wraparound.
0 open findings
What changed in this PR
Changes extended-timeout address-table allocation from random selection to bounded round-robin, complementing the related firmware work.
Changes:
- Adds a persistent cursor for sequential slot selection.
- Updates tests to verify sequential allocation and wraparound.
| File | Description |
|---|---|
| tests/test_ezsp_v4.py | Verifies sequential selection and wraparound. |
| tests/test_ezsp_v14.py | Updates the expected initial slot. |
| bellows/ezsp/v4/__init__.py | Replaces random selection with round-robin allocation. |
| bellows/ezsp/protocol.py | Initializes the address-table cursor. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #765 and NabuCasa/silabs-firmware-builder#236 for more context on the firmware side.
The address table actually contains the trust center address cache as a trailer so there's a small chance we can override an entry. Instead of randomly selecting entries, we round robin instead.