Repository navigation
Conversation
|
🤖 Hi @entrpn, I'm running an automatic MaxText review of this pull request. You can track my progress in the logs. To request another review later, add the |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This PR is part of the MaxText Model Deprecation & Lifecycle Policy, focusing on migrating test suites to use currently supported models. This ensures that test coverage remains relevant while phasing out sunset models, without impacting critical reference baselines. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
🤖 I'm sorry @entrpn, but I was unable to process your request. Please see the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
85eec3e to
01ec3af
Compare
|
🤖 Hi @entrpn, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
01ec3af to
6df5ba4
Compare
… retained Tier 1/2 configs (Phase 1b-1) Migrate generic unit, integration, and post-training test fixtures off sunset models (gpt3-52k, gemma-7b, gemma2-2b, llama2-7b, llama3-8b, mixtral-8x7b/8x22b, deepseek2-16b) onto retained Tier 1/2 configs (qwen3-0.6b, gemma3-4b, qwen3-30b-a3b, qwen3-235b-a22b, deepseek3-test, llama3.1-8b, llama3.3-70b), while preserving: - num_experts=8, num_experts_per_tok=2, and norm_topk_prob=False in RoutedMoE / fused_moe / router_replay unit tests - explicit q_lora_rank=0 MLA FLOPs and Muon dimension-number coverage - live decoder_block unit checks, llama2.LlamaDecoderLayer, llama4, pre-generated GCS checkpoint tests, and HLO diff baselines
6df5ba4 to
0137c99
Compare
Description
This is PR 1b-1 of the phased MaxText Model Deprecation & Lifecycle Policy rollout (split from the original 60-file PR into two focused, independent PRs so Python test fixture changes can be reviewed separately from auto-generated sharding JSON goldens):
configs/models/deprecated/<model_name>.ymlfallback resolution andDeprecationWarninginpyconfigandpyconfig_deprecated.gpt3-52k,gemma-7b,gemma2-2b,llama2-7b,llama3-8b,mixtral-8x7b/8x22b,deepseek2-16b) onto retained Tier 1/2 configs (qwen3-0.6b,gemma3-4b,qwen3-30b-a3b,qwen3-235b-a22b,deepseek3-test,llama3.1-8b,llama3.3-70b), while keepingllama4,llama2.py(LlamaDecoderLayer), livedecoder_blockunit checks (decoder_layer_model_mode_test.py), pre-generated GCS checkpoint tests (decode_tests.py,generate_param_only_checkpoint_test.py), and locked GitHub Actions HLO reference baselines (hlo_diff_test.py) untouched.tests/utils/sharding_dump.py(9MoE sharding cases) andtests/utils/run_sharding_dump.py(11modified lines of Python total) plus the36auto-generatedtests/utils/sharding_info/JSON golden files fromdeepseek2-16btodeepseek3-test.git mvof the sunset model configs intosrc/maxtext/configs/models/deprecated/+docs/reference/models/tiering.mdsync so generic unit/integration fixtures do not emit spuriousDeprecationWarnings.src/maxtext/tools/model_lifecycle_audit.py).Summary of Fixture Migrations (22 Python Files)
gpt3-52k->qwen3-0.6bintests/unit/aqt_serve_roundtrip_nnx_test.py, andmodel_name="gpt3-52k"->decoder_block=DecoderBlockType.GPT3intests/unit/nnx_decoders_test.py.gemma-7b/gemma2-2b->gemma3-4borqwen3-0.6bintests/unit/pyconfig_test.py,tests/unit/pyconfig_deprecated_test.py,tests/integration/diloco_test.py,tests/inference/benchmark_offline_engine.py, andtests/post_training/integration/grpo_trainer_correctness_test.py.llama2-7b/llama3-8b->llama3.1-8b/llama3.3-70bintests/unit/flop_calculation_test.py(retainingllama4-17b-16e),tests/unit/optimizers_test.py,tests/unit/muon_utils_test.py,tests/unit/configs_value_test.py,tests/unit/nnx_decoders_test.py,tests/unit/managed_mldiagnostics_test.py,tests/unit/rl_profiling_config_test.py,tests/unit/multimodal_utils_test.py,tests/post_training/unit/lora_utils_test.py, andtests/post_training/unit/rl_lr_schedule_test.py.mixtral-8x7b/mixtral-8x22b->qwen3-30b-a3b/qwen3-235b-a22b(preservingnum_experts=8,num_experts_per_tok=2, andnorm_topk_prob=Falsewhere tested) acrosstests/unit/moe_test.py,tests/unit/router_replay_test.py,tests/unit/pyconfig_test.py,tests/unit/defer_small_all_reduces_test.py,tests/unit/flop_calculation_test.py, andtests/equiv_chunk_test.py.deepseek2-16b->deepseek3-testacrosstests/unit/deepseek_decode_consistency_test.py,tests/unit/decoder_layer_model_mode_test.py,tests/unit/flop_calculation_test.py(also retaining explicitq_lora_rank=0MLA FLOPs coverage), andtests/unit/optimizers_test.py(also retaining explicitq_lora_rank=0Muon dimension-number coverage).Tests
pyconfig_test,pyconfig_deprecated_test,configs_value_test,flop_calculation_test,muon_utils_test,multimodal_utils_test,managed_mldiagnostics_test,rl_profiling_config_test,deepseek_decode_consistency_test,decoder_layer_model_mode_test,nnx_decoders_test,aqt_serve_roundtrip_nnx_test,defer_small_all_reduces_test,router_replay_test,optimizers_test,moe_test,lora_utils_test, andrl_lr_schedule_test), re-verified after rebasing ontomain.libtpu):tests/integration/diloco_test.py -k two_slices(4/4 passed).pyink --check,pylint,codespell): passed across all 22 modified Python files.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.