Repository navigation
Conversation
…2-16b to deepseek3-test (Phase 1b-2) Migrate tests/utils/sharding_dump.py MoE golden test cases off sunset deepseek2-16b onto retained Tier 1 deepseek3-test across all 9 TPU topology/rule combinations, and regenerate the corresponding tests/utils/sharding_info/ JSON golden files via run_sharding_dump.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is part of the ongoing MaxText Model Deprecation & Lifecycle Policy initiative. The primary objective is to transition test infrastructure away from sunset models by migrating sharding dump test cases to supported configurations. This ensures that the sharding verification suite remains aligned with the current model support tier while maintaining test coverage. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
🤖 Hi @entrpn, I'm running an automatic MaxText review of this pull request. You can track my progress in the logs. To request another review later, add the |
There was a problem hiding this comment.
📋 Review Summary
Verdict: No significant issues found.
Inferred spec & validation
- Sources: PR description, code after.
- Problem: Sharding dump test baselines and CLI examples depend on models (
deepseek2-16b,gemma-7b) that are being deprecated.
| Spec item | Implementation | Validating test |
|---|---|---|
R1 (stated): Migrate 9 MoE sharding dump cases to deepseek3-test. |
✅ | test_utils/sharding_dump.py ✅ |
R2 (stated): Update docstring example to gemma3-4b. |
✅ | test_utils/run_sharding_dump.py ✅ |
| R3 (stated): Generate new JSON sharding golden files. | ✅ | test_utils/run_sharding_dump.py ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Description
This is PR 1b-2 of the phased MaxText Model Deprecation & Lifecycle Policy rollout (split out from #6320 so reviewers can inspect the
22Python test fixture updates in #6320 separately from these auto-generated sharding JSON dumps):configs/models/deprecated/<model_name>.ymlfallback resolution andDeprecationWarninginpyconfigandpyconfig_deprecated.tests/utils/sharding_dump.pyoff sunsetdeepseek2-16bonto retained Tier 1deepseek3-test(and updates the CLI docstring example intests/utils/run_sharding_dump.pyfromgemma-7btogemma3-4b), removes the retiredtests/utils/sharding_info/deepseek2-16b/JSON goldens, and checks in freshly generatedtests/utils/sharding_info/deepseek3-test/(input_shardings.json,logical_shardings.json, andnamed_shardings.json) across all 9 topology/rule combinations (tpu7x-16,tpu7x-8, andv6e-16, includingpure-fsdp,pipeline-large-moe,ep-as-cp,cp-as-ep,tp-as-ep,ep-as-dp, andshard-exp-on-fsdp).git mvof the sunset model configs intosrc/maxtext/configs/models/deprecated/+docs/reference/models/tiering.mdsync.src/maxtext/tools/model_lifecycle_audit.py).Tests
deepseek3-testsharding dump cases (27JSON files acrosstpu7x-16,tpu7x-8, andv6e-16) against currentmainviapython3 -m tests.utils.run_sharding_dump(libtpuAOT topology mesh compilation), leaving the 3 unrelatedqwen3-0.6b/gpt-oss-20bbaselines untouched.pyink --check,pylint,codespell): passed ontests/utils/sharding_dump.pyandtests/utils/run_sharding_dump.py.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.