Repository navigation
Show the same readiness for approved PRs on Reviews and Team - #737
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
redreceipt
left a comment
There was a problem hiding this comment.
CI is failing. Please fix it and re-request my review.
|
@redreceipt I can't fix this one inside this PR. The only failing step is The cause is picomatch GHSA-fc5q-39xc-vjpf (high, ReDoS). Every published picomatch is affected ( Two ways to get green:
That's a CI policy call, so I'll leave the audit step alone unless you want option 2. I'll re-request your review as soon as |
|
The picomatch audit failure is addressed in #743 by moving |
🟢 e2e: 1 passedAll 1 test in 1 file
Tested by e2e 0.23.0 · 3.4s · web · run artifacts |
|
Please add screenshots to the PR description before requesting a review. |
|
@codex review this |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes APO-17965
On Reviews with "Include approved", approved PRs showed the raw CI state (for example "none") because approved rows have no blocker reason. Team's "Approved but unmerged" list uses
mergeBlocker(), so the same PR showed "Conflicts" there.Reviews now uses
mergeBlocker()for approved rows, so both pages show the same readiness (Stacked, Conflicts, CI failing, CI running, No CI status, Awaiting merge). Other sections are unchanged.Testing:
tsc --noEmit, eslint andnpm testpass locally. Added a check totests/reviews.e2e.tsthat the fixture's approved, conflicting "Login link expiry" shows "Conflicts" on Reviews.