Repository navigation
Move workflow to devDependencies so production audit can pass - #743
Conversation
npm audit --omit=dev has been failing since picomatch GHSA-fc5q-39xc-vjpf, which has no patched release. picomatch is a build-time transitive of workflow, so treating workflow as a devDependency lets the production audit pass without dropping Vercel Workflows.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🟢 e2e: 1 passedAll 1 test in 1 file
Tested by e2e 0.23.0 · 2.7s · web · run artifacts |
|
@codex review this |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
✅ Approved — No issues found across any review domain.✅ All checks passed 🔒 Security: ✅ LGTMNo security issues; moving a build-time-only package to devDependencies is a correct classification, not a suppressed runtime vulnerability. 📋 Code Quality: ✅ LGTMNo maintainability issues; moving build-only dependencies to devDependencies is standard. Performance and Compliance skipped (lite review) Apollos Code Review · Claude · $0.06 |
nlewis84
left a comment
There was a problem hiding this comment.
No issues found — human approval still required.
npm audit --omit=devhas been failing on main, #736, and #737 since the picomatch advisory GHSA-fc5q-39xc-vjpf was published. There is no patched picomatch release. The package is pulled in only at build time throughworkflow→@workflow/builders/@workflow/cli→tinyglobby→picomatch.This moves
workflowfromdependenciestodevDependencies. Next already bundles the app'sworkflow,workflow/api, andworkflow/nextimports at build, and Vercel installs devDependencies for builds, so the deployed app is unchanged. After the move,npm audit --omit=devreports 0 vulnerabilities. This unblocks main, #736, and #737 (APO-17965).Testing:
npm audit --omit=devexits 0npm run check(tsc + eslint) passesnpm test(105 passing)npm run buildsucceeds and compiles workflows (28 steps, 1 workflow)