Skip to content

Move workflow to devDependencies so production audit can pass - #743

Merged
apollos-medic[bot] merged 1 commit into
mainfrom
chore/move-workflow-to-dev-dependencies
Nov 18, 2026
Merged

apollos-medic[bot] merged 1 commit into
mainfrom
chore/move-workflow-to-dev-dependencies

Conversation

@apollos-medic

@apollos-medic apollos-medic Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

npm audit --omit=dev has been failing on main, #736, and #737 since the picomatch advisory GHSA-fc5q-39xc-vjpf was published. There is no patched picomatch release. The package is pulled in only at build time through workflow → @workflow/builders / @workflow/cli → tinyglobby → picomatch.

This moves workflow from dependencies to devDependencies. Next already bundles the app's workflow, workflow/api, and workflow/next imports at build, and Vercel installs devDependencies for builds, so the deployed app is unchanged. After the move, npm audit --omit=dev reports 0 vulnerabilities. This unblocks main, #736, and #737 (APO-17965).

Testing:

  • npm audit --omit=dev exits 0
  • npm run check (tsc + eslint) passes
  • npm test (105 passing)
  • npm run build succeeds and compiles workflows (28 steps, 1 workflow)

npm audit --omit=dev has been failing since picomatch GHSA-fc5q-39xc-vjpf,
which has no patched release. picomatch is a build-time transitive of
workflow, so treating workflow as a devDependency lets the production
audit pass without dropping Vercel Workflows.
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bug-board Ready Ready Preview Nov 18, 2026 1:50pm UTC

Request Review

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🟢 e2e: 1 passed

All 1 test in 1 file
Test Time
🟢 tests/reviews.e2e.ts · 1 passed 1.3s
🟢 review queue keeps blocked pull requests out of ready 1.3s

Tested by e2e 0.23.0 · 2.7s · web · run artifacts

@redreceipt

Copy link
Copy Markdown
Member

@codex review this

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T14:00:31.405072Z f4c0ff5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mary-pr-poppins mary-pr-poppins left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Mary PR Poppins — Approve

Looks clean across security, code quality, completeness, and repo history — no high-conviction issues found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: f4c0ff53c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nlewis84

Copy link
Copy Markdown

✅ Approved — No issues found across any review domain.

✅ All checks passed

🔒 Security: ✅ LGTM

No security issues; moving a build-time-only package to devDependencies is a correct classification, not a suppressed runtime vulnerability.

📋 Code Quality: ✅ LGTM

No maintainability issues; moving build-only dependencies to devDependencies is standard.

Performance and Compliance skipped (lite review)


Apollos Code Review · Claude · $0.06

@nlewis84 nlewis84 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found — human approval still required.

@apollos-medic
apollos-medic Bot merged commit 0576c8a into main Nov 18, 2026
4 checks passed
@apollos-medic
apollos-medic Bot deleted the chore/move-workflow-to-dev-dependencies branch November 18, 2026 16:25

This branch was successfully deployed

1 active deployment
Preview — f4c0ff53 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants