Repository navigation
Fix in-page button jumps (volunteer sign-up, ballot) - #111
Merged
Merged
Conversation
… nothing Button links to a #hash now render a plain <a>: next/link treated a click on a hash already in the URL as a no-op, so "Sign up to volunteer" didn't scroll on a second click or on a page opened at #signup. Same fix covers the #ballot button on when-is-the-election. FormstackForm now waits for Formstack's <form> to actually appear before calling the embed ready, and shows the open-in-a-new-tab fallback if it hasn't within 15 seconds, instead of a blank space. Failures are recorded in PostHog as formstack_form_failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
The volunteer pages are moving off Formstack, so it isn't needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
xrendan
changed the title
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button as="link"rendered anext/link, which treats a click on a hash that's already in the URL as a no-op navigation. The first click on "Sign up to volunteer" worked. After that (for example, after scrolling back up), or on a page opened at#signup, clicks updated the URL but didn't scroll.Buttonnow renders a plain<a>for#hashhrefs and lets the browser handle the jump. The same fix covers the#ballotbutton on when-is-the-election.Reproduced on production and verified locally: repeated clicks, and arriving at
#signup, now scroll every time.(An earlier commit here also added a Formstack render check. It has been dropped because the volunteer pages are moving off Formstack.)
🤖 Generated with Claude Code