Skip to content

Fix in-page button jumps (volunteer sign-up, ballot) #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrendan merged 2 commits into from
Oct 16, 2026
Merged

Fix in-page button jumps (volunteer sign-up, ballot) #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ad5f9
Fix in-page button jumps and show the fallback when Formstack renders…
xrendan Oct 16, 2026
22c1f42
Drop the Formstack render check
xrendan Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/components/ui/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,18 @@ export function Button(props: ButtonProps) {
);
}

// A jump within the page is left to the browser. next/link treats a click on
// a hash that's already in the URL as a no-op navigation, so the second
// click (or the first, on a page opened at that hash) wouldn't scroll.
if (props.href.startsWith("#")) {
return (
<a href={props.href} className={classes}>
{children}
<RightArrow />
</a>
);
}

// Default: internal link
return (
<Link href={props.href} className={classes}>
Expand Down
Loading