Skip to content

feat: caquick.com 도메인 허용(CORS·로그인 returnTo·S3 CORS) - #547

Merged
chanwoo7 merged 1 commit into
developfrom
feat/domain-caquick-com
Nov 1, 2026
Merged

chanwoo7 merged 1 commit into
developfrom
feat/domain-caquick-com

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Nov 1, 2026

Copy link
Copy Markdown
Member

개요

caquick.site(2026-11-29 만료)에서 caquick.com으로 도메인을 옮기기 위한 BE 준비 작업입니다.

  • 새 도메인을 옛 도메인과 나란히 허용만 합니다.
  • 운영 주소 전환(APP_ENV의 BACKEND_BASE_URL·FRONTEND_BASE_URL)은 FE 전환과 같은 시간대에 따로 진행합니다.

변경 사항

  • CORS 운영 목록: https://caquick.com·https://admin.caquick.com을 추가했습니다. .site는 만료까지 병행합니다.
  • 로그인 returnTo 허용 목록: https://caquick.com을 추가했습니다.
  • S3 CORS(terraform): allowed_origins에 같은 두 오리진을 추가했습니다. 머지 뒤 terraform apply로 반영합니다.
  • 문서: infra/app.env.example·README의 운영 주소를 .com으로 바꿨습니다.

테스트

  • CORS 운영 목록에 새 오리진 2개가 들어 있는지 확인합니다(it.each).
  • returnTo가 caquick.com·caquick.site 경로면 그대로 쓰는지 확인합니다.
  • 반증: 소스 변경을 되돌리면 새 테스트 3건이 실패합니다.

플랜 대조

플랜 1단계 BE PR 불릿 상태
cors-origins.ts에 .com 두 오리진 추가(.site 병행) 한 것
auth.constants.ts returnTo 허용 목록에 https://caquick.com 추가 한 것
terraform/aws.tf S3 CORS 추가 → terraform apply 한 것(apply는 머지 뒤)
infra/app.env.example·README*.md 운영 주소 .com 한 것
회귀 테스트: CORS·returnTo .com 허용 한 것

caquick.site가 2026-11-29 만료돼 caquick.com으로 옮긴다. 전환 전 준비로 새 오리진을 옛 도메인과 병행 허용만 하고, 운영 주소 전환은 FE와 같은 시간대에 APP_ENV로 한다.

- CORS 운영 목록: caquick.com·admin.caquick.com 추가
- returnTo 허용 목록: caquick.com 추가
- S3 CORS(terraform) 같은 두 오리진 추가
- app.env.example·README 운영 주소 .com
- 회귀 테스트 3건(CORS 2·returnTo 1)
@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-01T00:56:17.138348Z 202472c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

요약 항목 없음
전체 리포트
(knip 출력 없음 — 이슈 0이거나 실행 실패)

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 493건 (error 13).

Category error warning info
architecture 1 1 44
correctness 0 269 0
performance 0 41 28
schema 0 0 76
security 12 21 0
architecture / security 상위 항목
  • error security/security/no-hardcoded-secrets: Variable 'SEED_PASSWORD' appears to contain a hardcoded secret.
  • error architecture/architecture/no-manual-instantiation: Manual instantiation of 'OutboxRepository' detected. Use dependency injection instead.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'adminLogout' has no @UseGuards() at class or method level.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements
98.02% (+0.02% 🔼)
10805/11023
🟢 Branches
92.96% (+0.05% 🔼)
4120/4432
🟢 Functions 97.56% 2155/2209
🟢 Lines
98.6% (+0.02% 🔼)
9828/9968

Test suite run success

4318 tests passing in 388 suites.

Report generated by 🧪jest coverage report action from 202472c

@chanwoo7
chanwoo7 merged commit 09c658a into develop Nov 1, 2026
17 checks passed
@chanwoo7
chanwoo7 deleted the feat/domain-caquick-com branch November 1, 2026 00:59
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant