Shillelagh needs smoke to craft - #88207
Open
ahhwatson wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
<Bugfix>
ahhwatson
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
Aw heck I could have sworn I got rid of all those changes to recipe_others. I'll be fixing some stuff apparently. My master branch is all screwed up. Don't merge anything |
ahhwatson
force-pushed
the
smoky_shillelagh
branch
from
August 4, 2026 07:14
8af2f7e to
a0a4fd7
Compare
github-actions
Bot
added
the
json-styled
ahhwatson
changed the title
ahhwatson
commented
Aug 4, 2026
Contributor
Author
There was a problem hiding this comment.
No more random crafting recipes that put things into zipper bags. Apparently my master branch wasn't as clean as I thought. I've reset it to the current state of the CleverRaven repo, and done the same thing for the branch used in this PR, then re-implemented the one-line change I meant to include in this PR.
github-actions
Bot
added
the
BasicBuildPassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content "Shillelagh needs smoke"
Purpose of change
This PR resolves #87767.
Describe the solution
Add a smoking_heat requirement to the smoke-curing step of the shillelagh recipe.
Describe alternatives you've considered
Not doing this, reworking fireplaces to function as smokers for this purpose to bring the recipe more in line with historical accuracy.
Testing
I opened a character and observed that the smoke-curing step now correctly requires smoking heat.
Also, I ran the linter.
Additional context