Skip to content

Deliver fetch quest items via truck - #88308

Open
RenechCDDA wants to merge 1 commit into
CleverRaven:masterfrom
RenechCDDA:deliver_items_via_truck
Open

Deliver fetch quest items via truck#88308
RenechCDDA wants to merge 1 commit into
CleverRaven:masterfrom
RenechCDDA:deliver_items_via_truck

Conversation

@RenechCDDA

Copy link
Copy Markdown
Member

Summary

Features "Deliver fetch quest items via truck"

Purpose of change

Piling up solar panels on the ground is stupid

Describe the solution

Make it less stupid. They can come from your truck.

Includes:
-Hashing function for item_location (std::unordered_set support)
-A map function to "just give me the damn items" Cause items can be:
On a person
In a vehicle
On a map
Inside another item on one of the above
And all of that is terrible.

-Minor refactoring in f_consume_item_sum() to use the new function (and also because it was very difficult to follow)

Describe alternatives you've considered

Delete all pointless fetch quests

Testing

Balthazar ate 12 solar panels from me in each of the following combinations:

12 in truck

6 in truck, 6 in inventory

12 on ground

4 in truck, 4 in in inventory, 4 on ground

Additional context

@github-actions github-actions Bot added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` EOC: Effects On Condition Anything concerning Effects On Condition NPC / Factions NPCs, AI, Speech, Factions, Ownership json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 12, 2026
@RenechCDDA
RenechCDDA force-pushed the deliver_items_via_truck branch from e5d896c to 5d72ff1 Compare August 12, 2026 21:49
Including...
-Hashing function for item_location (std::unordered_set support)
-A map function to JUST GIVE ME ALL THE DAMN ITEMS AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
-We draw a little happy tree in f_consume_item_sum() as we refactor :)
@RenechCDDA
RenechCDDA force-pushed the deliver_items_via_truck branch from 5d72ff1 to babb0dd Compare August 12, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing EOC: Effects On Condition Anything concerning Effects On Condition json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant