Repository navigation
Show the bound key in key binding appendices - #255
Merged
Merged
Conversation
The appendix localized the key's save string, which shows a raw translation key such as "key.keyboard.z" for letter keys, and left out the key modifier. It now shows the same text as the Controls screen, such as "CTRL + Z". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
|
|
coverage: 26.786%. remained the same — fix-keybinding-appendix-key-name into master-1.21-lts |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keybindinginfo book appendix drewL10NHelpers.localize(keyBinding.saveString()). That only gives readable text for keys that have a lang entry, such as/or the arrow keys. Letter keys showed the rawkey.keyboard.z, and the key modifier was never shown, so a Ctrl+Z binding showed up askey.keyboard.z.It now uses
keyBinding.getTranslatedKeyMessage(), which is the same text the Controls screen shows (for exampleCTRL + ZorALT + Up Arrow). It also reflects rebinding.Found while adding a shortcuts section to the Integrated Scripting info book (CyclopsMC/IntegratedScripting#79).
Validation
key.keyboard.z,key.keyboard.y,key.keyboard.f,key.keyboard.g, with no modifiers. After:CTRL + Z,CTRL + Y,CTRL + F,CTRL + G,CTRL + /,ALT + Up Arrow,ALT + Down Arrow../gradlew buildand./gradlew :loader-neoforge:runGameTestServerpass.The same code is likely on the newer
master-*branches too, so it should carry over with the usual upmerge.Generated by Claude Code