Repository navigation
Conversation
Returns each of a wallet's xpubs keyed by its address format (bip84, bip49, bip44, bip32, newest first). The GUI uses this to show and copy each key separately instead of as one newline-joined block.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Description
Asana task
Implements
getDisplayPublicKeyson the UTXO currency tools. It returns each xpub keyed by its address format, newest format first:bip84,bip49,bip44,bip32. Formats the wallet lacks are left out.A modern BTC wallet returns its zpub (
bip84) and ypub (bip49) as two entries. The GUI labels them SegWit and Wrapped SegWit on separate copy rows, replacing the single newline-joined paragraph fromgetDisplayPublicSeed, which stays unchanged.Spec tests run per fixture wallet type: each derived xpub appears under its format, and entries come out in the newest-first order.
Note
Low Risk
Read-only display helper over existing public wallet keys; no changes to signing, sync, or key derivation.
Overview
Adds
getDisplayPublicKeysto UTXOmakeCurrencyTools, so the GUI can show each extended public key on its own row instead of one combined string fromgetDisplayPublicSeed.The method reads
publicKeysfrom wallet info viaasPublicKey, builds a format → xpub map, and only includes formats the wallet actually has. Iteration order is fixed (bip84→bip49→bip44→bip32) so newer address types appear first. The unreleased CHANGELOG notes the new tools API.Spec coverage runs across fixture wallet types: derived xpubs match under the right format key, and a dedicated case asserts newest-first ordering.
Reviewed by Cursor Bugbot for commit 348e37f. Bugbot is set up for automated code reviews on this repo. Configure here.