[peachbits]

Requested by Matthew

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

Asana task

RBF acceleration rebuilds a replacement from the stored inputs and outputs of the transaction being replaced. This makes the engine check that a stored unconfirmed spend carries the wallet's own signatures, and that the stored data matches the signed hex, before it builds on that record.

• verifyInputSignature (keymanager): loads the transaction into a PSBT the way makeTx builds one, lifts the signature and pubkey out of the finalized scriptSig or witness, and validates with Psbt.validateSignaturesOfInput, the same call signTx runs on every input it signs. SIGHASH_ALL only; p2pkh, p2wpkh and p2sh-p2wpkh inputs.
• verifyOwnInputSignatures (engine): applies it to every wallet-owned input, requires the stored inputs and outputs to be exactly the ones in the hex with each index listed once, and reports each input's proven value.
• accelerate(): requires a valid result, takes output scripts, input values and the replaced fee from the verified data, and returns spendTargets naming the replacement's recipients.
• Sync: a first-seen unconfirmed spend from the wallet whose signatures do not verify is not recorded. One the verifier cannot judge (no hex, an unsupported coin or script) is stored as before. Confirmed transactions are left alone.

Coins whose signing digest the PSBT validator does not reproduce (Bitcoin Gold, Groestlcoin, SmartCash) are reported as unverifiable. None of them enable RBF, so accelerate() is unaffected for them.

Testing

• test/common/utxobased/engine/verifyOwnInputSignatures.spec.ts covers bip44, bip49 and bip84 spends, the records the engine stores for its own sends (including a max spend and a replacement that adds an input), and the rejection cases.
• On an iOS simulator build with a testnet wallet: a pending send survives a wallet resync and Accelerate is still offered for it.

The GUI change that displays spendTargets is a separate PR in edge-react-gui.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[j0ntz]

Reviewed at 87178aa (high): nothing blocking. The inline comments carry two warnings and three suggestions.

Nit (commit-subject-50): 76f393b subject is 68 chars. Suggest Verify own input signatures before accelerating (47).

Rejected in curation (3)

• src/common/utxobased/engine/util/verifyOwnInputSignatures.ts:98: txid check returns invalid for coins whose txid hash differs from double-SHA256. Rejected: parsed.getId(coinInfo.txHashFunction) uses the coin's own hash function (Groestlcoin included).
• src/common/utxobased/engine/UtxoEngine.ts:198: accelerate() has no try/catch around the verifier. Rejected: a throw fails closed (no replacement is built) and surfaces to the GUI as an error, which is the safe outcome.
• src/common/utxobased/engine/UtxoEngine.ts:193: accelerate is now refused for transactions the verifier cannot check (eCash Schnorr, records stored before upgrade). Rejected: this is the PR's stated intent.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[peachbits]

All five inline comments are addressed in fixups. The commit subject is now Verify own input signatures before accelerating.