Repository navigation
Conversation
…mpkit, interface and utilities (#1103) Accuracy: - Dumper's registration example passes ext by keyword; register_dumper takes it keyword-only, so the positional form raised TypeError. - The strict -> reasm_strict rename and TraceFlow.register removal directives name 1.1.1, whose changelog records the 1.1.1.post2 change. Cross-references: - sys.excepthook and threading.excepthook are functions, so they use :func: and resolve through intersphinx. - The IP reassembly page documents _detect_conflicts, which the IP data model and the IPv4 and IPv6 pages link to. - The exceptions page documents _CaughtByCaller and says how it makes an error quiet. Wording: - "c.f." becomes "cf.", and the redundant "and etc." is dropped. - A list item in the PCAP-NG engine's read_frame ends with a semicolon. Refs #1103
|
NEEDS CHANGES at |
|
Question for the owner: the three new |
|
GOOD TO GO at |
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
|
GOOD TO GO at |
|
Changes in post releases marked by their own post releases or the next release - parent release does not contain the changes and can be confusing. |
|
Understood. A post-release change gets its own post-release in the directive, or the next release, because the parent release never shipped it. I'll change the three directives to |
- Mark the strict/reasm_strict rename on Extractor and extract(), and the removal of TraceFlowBase.register, with 1.1.1.post2, where they first shipped, rather than the parent 1.1.1. - Mark the OptionType int conversion on the const pcapng page with 1.1.0.post1 rather than 1.1.0, and move the #1884 guard's pin with it.
|
GOOD TO GO at |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseThe fourth whole-repo prose pass of #1103, over foundation, toolkit, dumpkit, interface and utilities. It changes prose only: every changed
.pyfile's AST is unchanged once string expressions are blanked, except where a docstring is added or vendor template text is edited together with its generated const file.Accuracy:
takes it keyword-only, so the positional form raised TypeError.
directives name 1.1.1, whose changelog records the 1.1.1.post2 change.
Cross-references:
:func: and resolve through intersphinx.
model and the IPv4 and IPv6 pages link to.
error quiet.
Wording:
Refs #1103