Repository navigation
docs(tests): fourth whole-repo pass over tests (#1103) - #1915
Conversation
Accuracy: - correct the pyproject.toml lines the linktype-209 gate cites, and say that cron-vendor.yml does run that pin when a crawl changes a constant - the MH default-argument cleanup comment no longer calls _missing_ loud or says it sets sys.tracebacklimit (#1845) - the builtin-parity rationale accounts for get()'s _CaughtByCaller block - conftest.py's docstring lists the session hooks it holds - the PyPCAPFile marker note names the legs by version, PyPy included - fix a "below" that pointed at a constant defined above it Counts: - reword codebase counts count-free in comments and docstrings, including the enum no-mint narrative and the arithmetic comment that no longer added up; the asserted constants carry the figures instead Timed context: - drop "today", "currently" and "as of <round>" where they added nothing Prose only: an AST guard with docstrings blanked is identical on every file. Refs #1103
|
NEEDS CHANGES at |
- test_const_linktype_209_unit: cite the pyproject note as :325-332, and drop "since #849" for a plain issue cite. - test_mh_unit: drop "any more" from the tracebacklimit cleanup comment. - Drop remaining counts of codebase items and timed wording ("now", "any more", "no longer", "since #") from comments and docstrings in test_const_enum_no_mint, test_const_method_value_lookup_908_unit, test_const_registry_protocol, test_fields_copy_dispatch_unit, test_ipv6_ext_unit, test_option_generator_tcp_base_unit, test_docstring_contract and test_vendor_missing_body_unit. Comments and docstrings only; the AST is unchanged.
|
NEEDS CHANGES at |
- test_const_enum_no_mint: say #860 step 2's PR 1 converted every bespoke class except AppType, rather than "most" of them. - Drop "now" and "any more" from the RulingConversionSourceTests comment. Comments and docstrings only; the AST is unchanged.
|
GOOD TO GO at |
|
Coverage: 90.07% (unit tier, Python 3.15,
Per-file detail: the |
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseThe fourth whole-repo prose pass of #1103, over test prose. It changes prose only: every changed
.pyfile's AST is unchanged once string expressions are blanked, except where a docstring is added or vendor template text is edited together with its generated const file.Accuracy:
that cron-vendor.yml does run that pin when a crawl changes a constant
or says it sets sys.tracebacklimit (design(const):
get(value, default)on an out-of-range value returns the default but logs a CRITICAL error and installs pcapkit's excepthook #1845)Counts:
the enum no-mint narrative and the arithmetic comment that no longer
added up; the asserted constants carry the figures instead
Timed context:
Prose only: an AST guard with docstrings blanked is identical on every file.
Refs #1103