Repository navigation
Copy from BitArrays to GPU arrays without scalar indexing - #849
Open
sasmith-14 wants to merge 1 commit into
Open
sasmith-14 wants to merge 1 commit into
sasmith-14 wants to merge 1 commit into
Conversation
The host-to-device `copyto!` methods only took `Array` sources, so a `BitArray` fell back to Base's elementwise copy. Unpack it into a `Vector` on the CPU first, as is already done for mismatched element types. Fixes JuliaGPU#836
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836.
copyto!from the host only handledArraysources, so aBitArrayfell back to Base's elementwise copy. This converts it to aVectoron the CPU first, like the mismatched-eltype method just above it.Added tests to the
copyto!testset; they fail without the fix and the full suite passes locally.(Used Claude to help with this; I've reviewed the change.)