Skip to content

Copy from BitArrays to GPU arrays without scalar indexing #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasmith-14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Copy from BitArrays to GPU arrays without scalar indexing #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/host/abstractarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,18 @@ function Base.copyto!(dest::AnyGPUArray{T}, dstart::Integer,
return dest
end

# `BitArray`s pack their elements into bits, so unpack them on the CPU too
function Base.copyto!(dest::AnyGPUArray{T}, dstart::Integer,
src::BitArray, sstart::Integer, n::Integer) where {T}
n == 0 && return dest
temp = Vector{T}(undef, n)
copyto!(temp, 1, src, sstart, n)
copyto!(dest, dstart, temp, 1, n)
return dest
end

Base.copyto!(dest::AnyGPUArray, src::BitArray) = copyto!(dest, 1, src, 1, length(src))

## generalized blocks of heterogeneous memory

# mirrors the checks of Base's `copyto!(dest, Rdest, src, Rsrc)`
Expand Down
23 changes: 23 additions & 0 deletions test/testsuite/base.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,29 @@ end
@test Array(src) == dst
end
end

# from a `BitArray`, without scalar indexing (#836)
let src = BitVector([true, false, true, true, false])
dst = AT{Bool}(undef, length(src))
copyto!(dst, src)
@test Array(dst) == src

dst = AT(fill(false, 7))
copyto!(dst, 2, src, 3, 2)
@test Array(dst) == [false, true, true, false, false, false, false]

src = BitMatrix([true false; false true])
dst = AT{Bool}(undef, 2, 2)
copyto!(dst, src)
@test Array(dst) == src
end
if Float32 in eltypes
let src = BitVector([true, false, true])
dst = AT{Float32}(undef, 3)
copyto!(dst, src)
@test Array(dst) == Float32[1, 0, 1]
end
end
end

@testset "copyto! of blocks" begin
Expand Down