Repository navigation
ci: the test, wheels and generated jobs free runner disk; the test build drops debug info - #776
Conversation
…ild drops debug info The `test` job runs out of disk on most open PRs. It already frees about 32 GB and builds with line tables, but on 2026-11-15 it started with 119 GB free and ended at 84 MB (#746, #756: the runner crashes with "No space left on device" and keeps no log), or ld died with SIGBUS while linking krishiv-server's tests (#772). - New composite action `.github/actions/free-disk`: the cleanup list the test, coverage and nightly jobs already used, plus removal of the preinstalled container images (as #768 did for diff-coverage), with `df -h /` before and after. - `test`: uses it; builds with `CARGO_PROFILE_DEV_DEBUG` and `CARGO_PROFILE_TEST_DEBUG` set to `false` (backtraces keep function names, lose line numbers; no test reads DWARF); removes the workspace run's test executables after the doctests, before the four feature-specific runs build their own; prints `df` and the size of `target` there and at the end. - `wheels` (both legs): uses the action; prints `df` at the end. - `generated` (docs-site.yml): uses the action, builds without debug info, prints `df` at the end. `diff-coverage` is unchanged: since #768 its runs end at 73-78% of the disk (#751, #772), and those two now fail the 90% added-line gate itself. Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@coderabbitai review |
Action not completed
|
dtolnay/rust-toolchain's `stable` branch was rewritten on 2026-11-15 02:32 UTC. The pinned commit b725eda5 no longer has history in that repository, so zizmor's impostor-commit audit now fails on every PR that touches a workflow (#769, #774). Repin the four uses (setup-rust action, binaries, docs-site) to the current `stable` head 39008827. Its action.yml is byte-identical to the old pin's, so the steps behave the same. Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
|
Diff review passed. Independent review of cbaa5be: the composite action has |
Signed-off-by: gopal tathe <44522021+techgopal@users.noreply.github.com>
Includes #775's toolchain repin. It is cherry-picked as its own commit: the four
dtolnay/rust-toolchainpins move fromb725eda5to39008827. #775 was ejected from the merge queue when itstestjob hit this disk problem, and #776 cannot pass zizmor without the repin, so the two land together here. #775 closes once this merges.The
testjob runs out of disk on most open PRs. It already frees about 32 GB and builds with line tables, but on 2026-11-15:#768 fixed only
diff-coverage. This PR extends the same treatment to the other heavy jobs.Changes
.github/actions/free-disk. It runs the cleanup list the test, coverage and nightly jobs already use, and also removes the preinstalled container images, as ci: diff-coverage builds without debug info, prunes container images and reports its disk use #768 does. It printsdf -h /before and after.test:CARGO_PROFILE_DEV_DEBUGandCARGO_PROFILE_TEST_DEBUGset tofalse(panic backtraces keep function names but lose line numbers; no test reads DWARF);dfand the size oftargetthere and at the end.wheels(both legs): uses the action and printsdfat the end.generated(docs-site.yml): uses the action, builds without debug info and printsdfat the end.diff-coverageis unchanged. Since #768 its runs end at 73–78% of the disk (#751, #772); those two now fail on the 90% added-line coverage gate itself, not on disk.Checks
zizmor1.30.1, offline, on the three changed files: no findings.zizmor1.30.1 online, on all of.github/with the repin: no findings.cargo xtask workflow-lint: OK.This PR changes ci.yml, so its own
testrun shows whether the build now fits: the newdf/dulines report it.