Repository navigation
test(fuzz): fix nightly soak's division-by-zero and ClickHouse 26.2 modulo failures - #134
Merged
Merged
Maple Review Bot / Maple / review
succeeded
Nov 5, 2026 in 1m 59s
Confidence 10/10 · No issues found
🟢 Confidence 10/10 · safe to merge. Test-only change; the new model floor is pinned by three fixed cases per target and the skip matcher is narrow and ClickHouse-gated.
no findings · tests covered · risk low
Makes the fuzz oracle decline any / or % whose divisor folds to zero as the SQL parses it, and replaces the UNION-only 26.2 modulo known issue with a plan-level, execution-gated one. Test-side only, no production code, safe to merge.
foldConstantfolds an expression asasParsedreads it, refusing a zero divisorevaluatedeclines a zero-divisor/or%before any row is readknownPlanIssuenarrows the 26.2 bug to a negative power-of-two divisor and gainsexecuted- Three fixed division cases replace the single one in
queries.fuzz.test.ts
What was checked
constant(e)/evalExprstill reach every node the old loop reached:ariths(asParsed(e))also carries argument subtrees (model.ts:313-318)UnionPlanholds no expression outsidebranches, and each branch is checked against the plan issues (queries.fuzz.test.ts:44)- The SQL
%divisor is always the plan node'srinflatten, so the matcher'sfoldConstant(e.r)never misses a parsed modulo
ba57dba · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.
Loading