Skip to content

[WIP] Add profile parameter rules and validation - #4076

Closed
JasonW404 wants to merge 3 commits into
feature/model-profile-normalizationfrom
feature/model-profile-parameter-rules
Closed

JasonW404 wants to merge 3 commits into
feature/model-profile-normalizationfrom
feature/model-profile-parameter-rules

Conversation

@JasonW404

@JasonW404 JasonW404 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

GitHub native stack

Stack #4080 targets develop, in order: #4072 → #4074 → #4076 → #4078 → #4079. All five PRs remain Draft. The stack is registered with GitHub, not represented only by titles or description links.

#4072 combines the contracts formerly split into #4071 with the TOML catalog/reader. #4071 is closed as superseded; its commits remain in #4072. No product commits were rewritten for this consolidation.

Changes

  • Compile and validate the declared finite parameter schema keywords; reject unsupported syntax, non-JSON/nonfinite values and coercion.
  • Preserve missing versus explicit null, false, zero and empty values.
  • Enforce independent editable/visible/required flags, outlet/conversation scopes, defaults and fixed values.
  • Evaluate explicit all/any + eq/in/exists conditions in dependency order; reject unknown references/cycles and explicit inactive values.
  • Return independent effective value views without modifying declarations or saved outlet values; diagnostics never echo submitted/fixed values.

This is a pure SDK parameter policy layer. Next #4078 will connect TOML supplements, profile composition and provider bindings. Database, frontend and NativeAgent changes remain later slices.

Verification

  • Local traditional UT: 337 model_service tests passed; aggregate coverage 97%; parameter rules 100%, finite schema 99%.
  • Ruff, diff checks and formal asset validation PASS. Existing source catalog D1 remains unchanged; isolated parameter rules are proved by traditional UT, not duplicated formal Cases. Connected composition proof is designed in the child PR.
  • Clean v2-6-1-docker-cache snapshot restored; native worktree mount; main/web/MCP built and infrastructure/application/Supabase deployed.
  • Installed Linux SDK parameter normal/error paths, immutable inputs and complete source catalog checks PASS.
  • Required SU/ADMIN/DEV/USER accounts and service health PASS; built-in browser homepage loaded v2.7.0.
  • CI unit/main/mcp/data-process PASS. Codecov patch coverage: 99.27798%.

AgentScope evaluation remains before NativeAgent kernel development. No dependency is introduced here.

@JasonW404
JasonW404 force-pushed the feature/model-profile-normalization branch from c9eeeaf to 2e7b3ac Compare October 13, 2026 04:31
@JasonW404
JasonW404 force-pushed the feature/model-profile-parameter-rules branch from 0733b50 to 508eb2e Compare October 13, 2026 04:50
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.27798% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nt/core/model_service/profiles/parameter_schema.py 98.54% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@JasonW404

Copy link
Copy Markdown
Member Author

Superseded by #4078 to reduce review overhead. All commits are already present in that consolidated Draft PR; no code or verification evidence has been discarded. Native GitHub Stack #4086 now contains #4078 → #4082 → #4083.

@JasonW404 JasonW404 closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant