Repository navigation
Rename the screens' private query() helpers - #76
Merged
Merged
Conversation
nativephp/mobile is adding a protected NativeComponent::query() for a screen's query string (NativePHP/mobile-air#401). A private query() in a screen can't override a protected one, so PHP would refuse to load AuthCallback and Remotes. They become callbackQuery() and remotesQuery(). No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
marked this pull request as ready for review
October 23, 2026 00:40
This was referenced Oct 23, 2026
ricardovfreixo
added a commit
to ricardovfreixo/dev-null-app
that referenced
this pull request
Oct 23, 2026
Take upstream's camera 1.1 release (NativePHP#73), SDK main baseline (NativePHP#75), the screens' private query() helper rename (NativePHP#76), the 4.2.0-rc.2 binaries (NativePHP#77), and keep the image viewer hanging over the commit sheet without handle-over-content, which mobile-ui no longer offers. Constrain nativephp/mobile to dev-fix/root-tab-reselect (f06d13c, based on mobile-air main with #557) and nativephp/mobile-ui to dev-fix/list-root-tab-scroll-target (28753b7), the reviewed pair the notification centre PR tests against, instead of mobile-ui main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nativephp/mobile is adding a protected
NativeComponent::query()that returns a screen's query string (NativePHP/mobile-air#401).AuthCallbackandRemoteseach have their ownprivate function query(), and PHP won't load a class that narrows an inherited method's visibility, so both screens would fail to load with a fatal error once that ships.This renames them to
callbackQuery()andremotesQuery(). Nothing else changes, and it works with the current mobile release as well as with NativePHP/mobile-air#401, so it can merge first.Once NativePHP/mobile-air#401 is released,
AuthCallbackcan drop its own parsing ofcurrentUri()and read$this->query()instead.Tests: the full suite passes (1193). I also ran it against the NativePHP/mobile-air#401 branch with the package symlinked in. Everything passed except the arch preset, which flags
debug_backtraceinside mobile'sNativeComponentbecause a symlinked package outsidevendor/looks like app code to it.🤖 Generated with Claude Code