Repository navigation
fix: serve the home page and the admin address under Valet and Herd - #521
Merged
Merged
Conversation
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #513.
Measured on macOS 15 (EC2 Mac, PHP 8.4, Valet 4.12, framework 13.38.0):
/answered a 302 to itself. Valet runs the site through its ownserver.php, which includespublic/index.php, soSCRIPT_FILENAMEis not the front controller;laravelIsServingTheRequest()said no andguardAgainstRawTemplateOutput()redirected to the home URL. A front controller PHP has included now counts./cms/wp-admin/(printed bypollora:install) answered 404: Valet hands every URL that is not a file to the front controller. A request for apublic/directory with anindex.phpis redirected to that file.After both changes, on the same Mac:
/200,/cms/wp-admin/→index.php→ login, no redirect loop, WordPress pages and 404 unchanged.Tests: new cases in
LaravelServingRequestTest, newPublicDirectoryIndexRedirectTest; PHPStan clean. 11 Feature tests (async/database queue) fail the same way on develop in my environment.