Skip to content

Solve the bug of column name is accession. - #913

Open
EstelleDa wants to merge 11 commits into
release-2026.3.3from
bugfix/estelle/844/csvExport
Open

EstelleDa wants to merge 11 commits into
release-2026.3.3from
bugfix/estelle/844/csvExport

Conversation

@EstelleDa

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Oct 9, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39720696646

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Warning

No base build found for commit e52f665 on release-2026.3.2.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 90.354%

Details

  • Patch coverage: 10 of 10 lines across 5 files are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 19189
Covered Lines: 17338
Line Coverage: 90.35%
Coverage Strength: 0.9 hits per line

💛 - Coveralls

@EstelleDa
EstelleDa requested a review from bencap October 9, 2026 05:50
Base automatically changed from release-2026.3.0 to main October 16, 2026 17:08
@EstelleDa
EstelleDa changed the base branch from main to release-2026.3.1 October 19, 2026 04:24
@bencap
bencap changed the base branch from release-2026.3.1 to release-2026.3.2 October 19, 2026 18:03

@bencap bencap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good! I think we should also add a couple router tests that assert the behavior at the user level:

  • A test that new uploads with an accession column fail validation and return the appropriate error to the user.
  • A test that exporting an accession column returns a 200.

Comment on lines +1 to +6
# ruff: noqa: E402

import pytest

fastapi = pytest.importorskip("fastapi")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can come out of the file now since the stuff upstream is merged. But if there are errors again lmk.

EstelleDa and others added 2 commits October 22, 2026 14:52
bin/check's ruff format disagreed with the local pinned version on how
to lay out the multi-line CSV string literals.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Base automatically changed from release-2026.3.2 to main October 22, 2026 06:50
@EstelleDa
EstelleDa changed the base branch from main to release-2026.3.3 October 23, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV export returns 500 when a column is named accession or the variant is deleted mid-request

3 participants