Repository navigation
Conversation
Saving a file in the editor sorted its imports, but bin/check never checked import order, so edits picked up reordering unrelated to the change. Selecting "I" makes the CLI enforce the same order the editor applies. This commit is the rule change and Ruff's fixes only, in 87 files: reorders within import groups and dropped blank lines after imports.
Coverage Report for CI Build 39865049119Coverage decreased (-0.06%) to 90.341%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
bencap
marked this pull request as ready for review
October 23, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The editor's organize-imports on save applies Ruff's import-sorting rules, but
bin/checkdidn't select them, so saving a file reordered its imports and those reorders showed up in unrelated diffs. This adds"I"to[tool.ruff.lint] selectso the CLI and CI enforce the same order the editor applies.select = ["E4", "E7", "E9", "F", "I"]inpyproject.toml.--fixoutput only, in 87 files (three are stubs inmypy_stubs/): reorders within import groups and dropped blank lines after imports. No hand edits.For open branches: after rebasing onto this, run
poetry run ruff check --fixto sort any imports the branch added.Tests
No new tests; it changes no behavior. Ran
bin/check(clean) and the PR suite,bin/t tests/ -n 6 -m "not network and not slow": 5,433 passed, 22 skipped. The full suite was run because reordering imports can change module side effects, such as model registration.Checklist
release-<year>.<n>.0branch otherwise; never
mainmavedb-uiPR regeneratessrc/schema/openapi.d.ts(no schema change)