Repository navigation
Conversation
Reflects VariantEffect/mavedb-api#949, which stores DOI, raw read and target gene identifiers on the rows that cite them: DoiIdentifier and RawReadIdentifier lose id, ExternalGeneIdentifier loses referenceHtml, and the identifier search routes accept X-Active-Roles.
DOIs are case-insensitive and the api now stores them upper-cased, so a DOI added in another case is the same citation.
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ui half of VariantEffect/mavedb-api#949, which stores DOI, raw read and target gene identifiers on the rows that cite them and upper-cases DOIs.
src/schema/openapi.d.tsregenerated from that PR.DoiIdentifierandRawReadIdentifierloseid,ExternalGeneIdentifierlosesreferenceHtml, and the identifier search routes acceptX-Active-Roles. The ui read none of the removed fields.Merge together with VariantEffect/mavedb-api#949.
Tests
bin/check,bin/t(540 passed) and the app build.form-helpers.tsimportsorcid.ts, which readswindowat import, so it can't load in vitest's node environment.Checklist
release-<year>.<n>.0branch otherwise; never
mainmavedb-apiPR is linked, andsrc/schema/openapi.d.tsis regenerated from it