Skip to content

chore(schema): regenerate API types for identifiers stored on owner rows - #755

Open
bencap wants to merge 2 commits into
release-2026.3.2from
feature/bencap/identifiers-on-owner-rows
Open

bencap wants to merge 2 commits into
release-2026.3.2from
feature/bencap/identifiers-on-owner-rows

Conversation

@bencap

@bencap bencap commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

The ui half of VariantEffect/mavedb-api#949, which stores DOI, raw read and target gene identifiers on the rows that cite them and upper-cases DOIs.

  • Types: src/schema/openapi.d.ts regenerated from that PR. DoiIdentifier and RawReadIdentifier lose id, ExternalGeneIdentifier loses referenceHtml, and the identifier search routes accept X-Active-Roles. The ui read none of the removed fields.
  • DOI duplicates: adding a DOI that's already on the record in another case is now caught as a duplicate, since the api treats them as one.

Merge together with VariantEffect/mavedb-api#949.

Tests

  • Ran bin/check, bin/t (540 passed) and the app build.
  • No unit test for the duplicate check: form-helpers.ts imports orcid.ts, which reads window at import, so it can't load in vitest's node environment.

Checklist

  • Targets the open patch branch if this is a small, non-breaking change, or the cycle's release-<year>.<n>.0
    branch otherwise; never main
  • Needs an API change? The mavedb-api PR is linked, and src/schema/openapi.d.ts is regenerated from it
  • Docs and instruction files touched by this change are updated

Reflects VariantEffect/mavedb-api#949, which stores DOI, raw read and
target gene identifiers on the rows that cite them: DoiIdentifier and
RawReadIdentifier lose id, ExternalGeneIdentifier loses referenceHtml,
and the identifier search routes accept X-Active-Roles.
DOIs are case-insensitive and the api now stores them upper-cased, so
a DOI added in another case is the same citation.
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 23.891%. remained the same — feature/bencap/identifiers-on-owner-rows into release-2026.3.2

@bencap bencap added this to the R2026.4 milestone Oct 23, 2026
@bencap
bencap marked this pull request as ready for review October 23, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: frontend Task implementation touches the frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store DOI, raw read and target gene identifiers on the rows that use them

2 participants