Repository navigation
Conversation
tisonkun
marked this pull request as draft
October 24, 2026 02:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
estimated_sizeimplementations while keeping all 17 public documentation comments implementation-neutral.size_of::<P>()forTupleSketchand the shared union/intersection state so potentially large inline policy payloads are represented. Built-in zero-sized policies are unchanged.CpcWrapperwithoutestimated_size: it contains only fixed-size cardinality metadata and owns no variable-sized storage.Returns an estimate of memory usage in bytes.Implementation notes
The inline audit found no configuration-scaled inline buffers in the covered types. Substantial variable-sized state is owned by
VecorBox<[T]>. Custom Tuple policies can have large inline payloads and are now included throughsize_of::<P>(); generic values' recursively owned allocations remain a separate design topic in #193.No KLL/REQ methods are added. Public method documentation remains a single sentence that does not prescribe heap, inline layout, capacity, or generic traversal rules.
Validation
cargo x checkcargo x testcargo x lint