Repository navigation
fix(examples): bump FastAPI and Flask pin sets together - #922
Conversation
Dependabot bumped single pins in these fully pinned requirements files, which broke installs: starlette 1.3.1 against fastapi 0.115.5 (needs starlette<0.42), and Flask 3.1.3 against blinker 1.6.2 (needs >=1.9). Bump each set as a whole to versions that clear the open alerts: - fastapi, fastapi-zip, fastapi-background-tasks: fastapi 0.141.1 (newest release before the opentelemetry-api dependency), starlette 1.10.0, anyio 4.16.0, idna 3.20, pydantic 2.14.3 / pydantic-core 2.50.4, plus fastapi's new deps annotated-doc and typing-inspection. background-tasks also gets certifi 2026.10.23, requests 2.34.2 and urllib3 2.8.0. - flask-zip: Flask 3.1.3, Werkzeug 3.1.9, Jinja2 3.1.6, blinker 1.9.0, itsdangerous 2.2.0 (Flask 3.1 requires >=2.2). Supersedes #857, #860, #869 and #863.
vicheey
left a comment
There was a problem hiding this comment.
Thanks for bundling these. Bumping each set as a whole looks right, and every open alert on these four files lands at or above its patched version.
A couple of follow-ups, none blocking:
examples/flask/app/requirements.txthas the same pins flask-zip had before this PR (Flask==3.1.3withblinker==1.6.2anditsdangerous==2.1.2), so it won't install either. Could it get the sameblinker==1.9.0/itsdangerous==2.2.0bump here, so the two Flask examples stay in step?- Six more FastAPI examples on main pin
fastapi==0.115.5withstarlette==1.3.1(bedrock-agent-fastapi(-zip), fastapi-response-streaming(-zip), fastapi-snapstart(-zip)), and fastapi-backend-only-response-streaming hasbotocore==1.31.61withurllib3==2.8.0. None of them are in the example matrix, which is how those bumps merged. Happy for that to be a separate PR. - Optional: a
pip install --dry-run -rstep for changedexamples/**/requirements.txtin Verify Examples would catch this kind of single-pin bump for examples outside the matrix. - Nit (optional):
sniffiois no longer needed by anyio 4.16, so it could come out of the three FastAPI files.
Flask 3.1.3 needs blinker>=1.9 and itsdangerous>=2.2; match flask-zip. anyio 4.16 no longer depends on sniffio, so drop it from the FastAPI examples touched by this PR.
|
Thanks for the careful review! 1 and 4: pushed to this PR. examples/flask now uses blinker 1.9.0 / itsdangerous 2.2.0, and sniffio is removed from the three FastAPI files. I checked anyio 4.16.0's metadata first, and nothing else in those files depends on sniffio. |
vicheey
left a comment
There was a problem hiding this comment.
Let's update the branch. Overall looks good. Thanks!
Dependabot bumped single pins in these fully pinned
requirements.txtfiles, which breaks the install:starlette 1.3.1againstfastapi 0.115.5(needsstarlette<0.42), andFlask 3.1.3againstblinker 1.6.2(needs>=1.9). This PR bumps each set as a whole, to versions at or above every open alert's patched version:opentelemetry-apidependency), starlette 1.10.0, anyio 4.16.0, idna 3.20, pydantic 2.14.3 / pydantic-core 2.50.4, plus fastapi's new depsannotated-docandtyping-inspection. background-tasks also gets certifi 2026.10.23, requests 2.34.2 and urllib3 2.8.0.>=2.2).Testing
On Python 3.12, with a fresh venv per example:
pip install -r requirements.txtsucceeds andpip checkreports no broken requirements, for all 4.GET /in-process returns 200 with themessagebody the example matrix expects.All four examples are in the build matrix, so CI boots them on this PR.
Supersedes
Dependabot should close these once this merges.