Skip to content

fix(examples): align remaining FastAPI pin sets with starlette 1.x - #930

Open
bnusunny wants to merge 1 commit into
mainfrom
fix/fastapi-pin-sets-rest
Open

bnusunny wants to merge 1 commit into
mainfrom
fix/fastapi-pin-sets-rest

Conversation

@bnusunny

Copy link
Copy Markdown
Contributor

Follow-up to #922, from @vicheey's review there.

Seven examples on main pin sets that pip install cannot resolve:

  • bedrock-agent-fastapi, bedrock-agent-fastapi-zip, fastapi-response-streaming, fastapi-response-streaming-zip, fastapi-snapstart, fastapi-snapstart-zip: fastapi 0.115.5 with starlette 1.3.1
  • fastapi-backend-only-response-streaming: fastapi 0.109.2 with starlette 1.3.1, and botocore 1.31.61 (urllib3 < 2.1) with urllib3 2.8.0

Changes:

  • Use the same FastAPI set as fix(examples): bump FastAPI and Flask pin sets together #922 (fastapi 0.141.1, starlette 1.10.0, pydantic 2.14.3, anyio 4.16.0, ...).
  • fastapi-backend-only-response-streaming: boto3/botocore 1.35.63 + s3transfer 0.10.3 (urllib3 2.x compatible), the same as the other boto examples. urllib3 stays at 2.8.0, the highest patched version in open Dependabot alerts.
  • Drop sniffio (anyio 4.16 no longer needs it) and exceptiongroup (anyio needs it only on Python < 3.11; these run on 3.12).

Verified: pip install --dry-run --ignore-installed -r on Python 3.12 fails on main and passes on this branch for all seven files.

fastapi 0.115.5 / 0.109.2 cannot install with the pinned starlette 1.3.1,
and botocore 1.31.61 caps urllib3 below 2.1 while urllib3 is pinned at 2.8.0.

Use the fastapi 0.141.1 / starlette 1.10.0 set from #922, bump
boto3/botocore to 1.35.63 (urllib3 2.x compatible) in
fastapi-backend-only-response-streaming, and drop sniffio and
exceptiongroup, which nothing needs on Python 3.12.

Follow-up to review feedback on #922.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant