Repository navigation
fix: use awaited vite-node entry for ESM eval retries - #422
Merged
Merged
Conversation
Declare vite-node in both ESM retry fixtures so Node 20 does not depend on an on-demand npm install.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 16, 2026
Stephen Belanger (Qard)
approved these changes
Oct 16, 2026
Stephen Belanger (Qard)
pushed a commit
that referenced
this pull request
Oct 16, 2026
Stacked on #422, which isolates the ESM eval CI fix. Merge that PR first. Carry a facet's Topics automation settings when copying it between projects. Schema v2 adds `topics_automations`: each referenced automation's name, description, and API-returned config. This includes scope, automation filter, sampling, model, status, and timing. Project-specific `facet_functions` and `topic_map_functions` are excluded and rebuilt in the destination. Pull selects settings by bound automation ID and repeats that selection after the facet picker. An unrelated same-name automation does not block export. IDs stay internal; template references remain names. Push behavior: - New automation: use the bundled settings and description. - Matching settings and description: retain them without requiring force for the settings. Existing facet/preprocessor replacement rules still apply. - Different settings or description: require `--force`. Replace settings in full while preserving destination wiring. Destination-only settings are dropped and the description can be cleared. - `--topics-automation`: use the selected destination's settings instead. Version 1 templates remain readable. Specific experiment IDs produce an error naming the facet and automation because they cannot be carried between projects. Timing validation and normalization stay on the server. Checks: 24 focused observability tests passed, covering settings round trips, push cases, API request contents, and automation-ID selection. Formatting and Clippy passed, with the existing root enum warning suppressed. A live pull verified three prompt facets, their shared saved preprocessor, and span-scoped Topics settings. No live destination push was performed. No backend changes are required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the ESM eval retry failures uncovered by Node 20 CI on #409. The underlying issues already exist on main.
Validation: the Node 20 eval fixture cohort passed locally. All CI checks passed with this patch on #409; this PR isolates the same three-file change for review.
Merge this before #409, which is stacked on this branch.