Repository navigation
feat: preserve scoped Topics settings in observability templates - #409
Merged
Stephen Belanger (Qard) merged 13 commits intoOct 16, 2026
Merged
Stephen Belanger (Qard) merged 13 commits into
Stephen Belanger (Qard) merged 13 commits into
Conversation
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
This was referenced Oct 8, 2026
max-braintrust
force-pushed
the
max/observability-template-automation-settings
branch
from
October 8, 2026 22:24
19f9192 to
f7c6f42
Compare
max-braintrust
changed the base branch from
main
to
max/observability-duplicate-topic-map-repair
October 8, 2026 22:24
max-braintrust
force-pushed
the
max/observability-template-automation-settings
branch
from
October 13, 2026 17:02
592624f to
aff70a4
Compare
max-braintrust
force-pushed
the
max/observability-duplicate-topic-map-repair
branch
from
October 13, 2026 17:02
b3261bb to
494b7e4
Compare
max-braintrust
force-pushed
the
max/observability-template-automation-settings
branch
from
October 14, 2026 17:28
bc85730 to
e375291
Compare
# Conflicts: # README.md # src/observability/push.rs
max-braintrust
marked this pull request as ready for review
October 14, 2026 17:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c78e99e6a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
pushed a commit
that referenced
this pull request
Oct 15, 2026
Stack 1/2. Base: `main`. Next: [scoped Topics settings (#409)](#409). Review and merge this PR first. Older template pushes could attach another map when a facet already had one under a different slug. Later pushes failed on those multiple maps. Repair also removed the facet and map from other automations, even when those bindings were valid. With `--force`, push selects the map with the generated template slug, or creates it if needed. It detaches superseded maps only from the selected destination automation. Other automations keep their facet and map bindings. An existing matching map retains its customization and saved state. A newly created map needs generation before it can classify. Push does not regenerate topics or replay historical classifications. Detached map functions remain in the project and are listed in human and JSON output. They may still be referenced by other automations. The removal planner takes only the destination mutations, selected destination key, and superseded maps. Its four unused parameters have been removed. Checks: 17 focused `active_observability` tests passed, including selected-map replacement and preservation of another automation's shared-facet binding. Cargo formatting and `git diff --check` passed. Both branches include current main.
Base automatically changed from
max/observability-duplicate-topic-map-repair
to
main
October 15, 2026 09:13
# Conflicts: # README.md
Declare vite-node in both ESM retry fixtures so Node 20 does not depend on an on-demand npm install.
Declare vite-node in both ESM retry fixtures so Node 20 does not depend on an on-demand npm install.
…-automation-settings
Stephen Belanger (Qard)
pushed a commit
that referenced
this pull request
Oct 16, 2026
Fix the ESM eval retry failures uncovered by Node 20 CI on #409. The underlying issues already exist on main. - Use the existing awaited vite-node entrypoint for automatic ESM retries. #203 added this entrypoint but missed the retry path. - Add vite-node to both retry fixtures so tests install it upfront. Node 20's npm resolver crashes when the fixtures fetch it through npx at runtime. Validation: the Node 20 eval fixture cohort passed locally. All CI checks passed with this patch on #409; this PR isolates the same three-file change for review. Merge this before #409, which is stacked on this branch.
Stephen Belanger (Qard)
approved these changes
Oct 16, 2026
Stephen Belanger (Qard)
deleted the
max/observability-template-automation-settings
branch
October 16, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #422, which isolates the ESM eval CI fix. Merge that PR first.
Carry a facet's Topics automation settings when copying it between projects.
Schema v2 adds
topics_automations: each referenced automation's name, description, and API-returned config. This includes scope, automation filter, sampling, model, status, and timing. Project-specificfacet_functionsandtopic_map_functionsare excluded and rebuilt in the destination.Pull selects settings by bound automation ID and repeats that selection after the facet picker. An unrelated same-name automation does not block export. IDs stay internal; template references remain names.
Push behavior:
--force. Replace settings in full while preserving destination wiring. Destination-only settings are dropped and the description can be cleared.--topics-automation: use the selected destination's settings instead.Version 1 templates remain readable. Specific experiment IDs produce an error naming the facet and automation because they cannot be carried between projects. Timing validation and normalization stay on the server.
Checks: 24 focused observability tests passed, covering settings round trips, push cases, API request contents, and automation-ID selection. Formatting and Clippy passed, with the existing root enum warning suppressed. A live pull verified three prompt facets, their shared saved preprocessor, and span-scoped Topics settings. No live destination push was performed. No backend changes are required.