Skip to content

fix Table to respect react key prop - #1726

Closed
ZigZagT wants to merge 2 commits into
bvaughn:masterfrom
ZigZagT:fix_key_prop_support_for_table
Closed

ZigZagT wants to merge 2 commits into
bvaughn:masterfrom
ZigZagT:fix_key_prop_support_for_table

Conversation

@ZigZagT

@ZigZagT ZigZagT commented Mar 9, 2022

Copy link
Copy Markdown

Attempting to fix #1725

  • The existing test suites (npm test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).
  • Run the Flow typechecks (yarn run typecheck).

@ZigZagT

ZigZagT commented Jul 19, 2022

Copy link
Copy Markdown
Author

@bvaughn Can we get this fix merged (or closed)? I know this project is not actively worked on anymore, yet it still will be nice to get this fix to make life easier for some folks (like us) :)

@ZigZagT ZigZagT closed this Oct 30, 2022
@ZigZagT

ZigZagT commented Oct 30, 2022

Copy link
Copy Markdown
Author

closing due to no response from the maintainer.

@ZigZagT
ZigZagT deleted the fix_key_prop_support_for_table branch October 30, 2022 00:58
@bvaughn

bvaughn commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Sorry for the very long delay in getting back to you about this!

I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from source/ to lib/. Because of that, this PR can't be merged as-is. Version 10's Table keys its cells by each Column's key (so cells follow reordered columns), but rows are still keyed by their index, so the scenario in #1725 still applies.

If you're still interested in this change, I'd welcome a new PR with it rebased onto the version-10 branch (or onto master once version 10 has been merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React key prop is not respected in Table/Column

2 participants