Skip to content

fix Table to respect react key prop #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZigZagT wants to merge 2 commits into from
Closed

fix Table to respect react key prop #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aef02b
respect react key prop
Mar 9, 2022
92f1c9e
add ut
Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions source/Table/Table.jest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,4 +1563,34 @@ describe('Table', () => {
findDOMNode(render(getMarkup({cellRenderer})));
expect(cellRenderer.mock.calls[0][0].parent).not.toBeUndefined();
});

it('`key` prop rendered on cells should work as expected', () => {
let mutableList = [
{id: 1, name: 'foo'},
{id: 2, name: 'bar'},
{id: 3, name: 'baz'},
];
const rerender = () =>
findDOMNode(
render(
getMarkup({
rowGetter: ({index}) => mutableList[index],
cellRenderer: props => (
<div key={props.cellData} id={props.cellData}>
Cell
</div>
),
rowCount: mutableList.length,
}),
),
);
let rendered = rerender();
expect(rendered.querySelector('#foo')).toBeTruthy();
const bazElem = rendered.querySelector('#baz');
mutableList = mutableList.slice(1);
rendered = rerender();
expect(rendered.querySelector('#foo')).toBeFalsy();
// dom node should have been reused when `key` worked
expect(rendered.querySelector('#baz')).toBe(bazElem);
});
});
9 changes: 6 additions & 3 deletions source/Table/Table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,10 @@ export default class Table extends React.PureComponent {
aria-colindex={columnIndex + 1}
aria-describedby={id}
className={clsx('ReactVirtualized__Table__rowColumn', className)}
key={'Row' + rowIndex + '-' + 'Col' + columnIndex}
key={
(renderedCell && renderedCell.key) ||
`Row${rowIndex}-Col${columnIndex}`
}
onClick={onClick}
role="gridcell"
style={style}
Expand Down Expand Up @@ -598,7 +601,7 @@ export default class Table extends React.PureComponent {
aria-sort={headerAriaSort}
className={classNames}
id={id}
key={'Header-Col' + index}
key={column.key || `Header-Col${index}`}
onClick={headerOnClick}
onKeyDown={headerOnKeyDown}
role="columnheader"
Expand Down Expand Up @@ -658,7 +661,7 @@ export default class Table extends React.PureComponent {
columns,
index,
isScrolling,
key,
key: (columns[0] && columns[0].key) || key,
onRowClick,
onRowDoubleClick,
onRowRightClick,
Expand Down