Repository navigation
Add EveVolumeObject for placing box volumes in a scene - #119
Merged
Merged
Conversation
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/trinity/Eve/EveVolumeObject.cpp b/trinity/Eve/EveVolumeObject.cpp
index d5e6811..76f491b 100644
--- a/trinity/Eve/EveVolumeObject.cpp
+++ b/trinity/Eve/EveVolumeObject.cpp
@@ -149,2 +149 @@ void EveVolumeObject::ResolveBoxVolume()
- m_boxChangeCallbackID = m_boxVolume->RegisterForChanges( [this]()
- {
+ m_boxChangeCallbackID = m_boxVolume->RegisterForChanges( [this]() {
@@ -178,4 +177 @@ bool EveVolumeObject::TransformsNearlyEqual( const Matrix& a, const Matrix& b )
- return XMVector3NearEqual( a.GetX(), b.GetX(), axisEpsilon )
- && XMVector3NearEqual( a.GetY(), b.GetY(), axisEpsilon )
- && XMVector3NearEqual( a.GetZ(), b.GetZ(), axisEpsilon )
- && XMVector3NearEqual( a.GetTranslation(), b.GetTranslation(), translationEpsilon );
+ return XMVector3NearEqual( a.GetX(), b.GetX(), axisEpsilon ) && XMVector3NearEqual( a.GetY(), b.GetY(), axisEpsilon ) && XMVector3NearEqual( a.GetZ(), b.GetZ(), axisEpsilon ) && XMVector3NearEqual( a.GetTranslation(), b.GetTranslation(), translationEpsilon );
diff --git a/trinity/Eve/Volume/EveBoxVolume.h b/trinity/Eve/Volume/EveBoxVolume.h
index 4790083..6073bb1 100644
--- a/trinity/Eve/Volume/EveBoxVolume.h
+++ b/trinity/Eve/Volume/EveBoxVolume.h
@@ -40 +40,4 @@ public:
- const Matrix& GetBoxTransform() const { return m_boxTransform; }
+ const Matrix& GetBoxTransform() const
+ {
+ return m_boxTransform;
+ }
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/trinity/Eve/EveVolumeObject.cpp b/trinity/Eve/EveVolumeObject.cpp
index d5e6811..76f491b 100644
--- a/trinity/Eve/EveVolumeObject.cpp
+++ b/trinity/Eve/EveVolumeObject.cpp
@@ -149,2 +149 @@ void EveVolumeObject::ResolveBoxVolume()
- m_boxChangeCallbackID = m_boxVolume->RegisterForChanges( [this]()
- {
+ m_boxChangeCallbackID = m_boxVolume->RegisterForChanges( [this]() {
@@ -178,4 +177 @@ bool EveVolumeObject::TransformsNearlyEqual( const Matrix& a, const Matrix& b )
- return XMVector3NearEqual( a.GetX(), b.GetX(), axisEpsilon )
- && XMVector3NearEqual( a.GetY(), b.GetY(), axisEpsilon )
- && XMVector3NearEqual( a.GetZ(), b.GetZ(), axisEpsilon )
- && XMVector3NearEqual( a.GetTranslation(), b.GetTranslation(), translationEpsilon );
+ return XMVector3NearEqual( a.GetX(), b.GetX(), axisEpsilon ) && XMVector3NearEqual( a.GetY(), b.GetY(), axisEpsilon ) && XMVector3NearEqual( a.GetZ(), b.GetZ(), axisEpsilon ) && XMVector3NearEqual( a.GetTranslation(), b.GetTranslation(), translationEpsilon );
diff --git a/trinity/Eve/Volume/EveBoxVolume.h b/trinity/Eve/Volume/EveBoxVolume.h
index 4790083..6073bb1 100644
--- a/trinity/Eve/Volume/EveBoxVolume.h
+++ b/trinity/Eve/Volume/EveBoxVolume.h
@@ -40 +40,4 @@ public:
- const Matrix& GetBoxTransform() const { return m_boxTransform; }
+ const Matrix& GetBoxTransform() const
+ {
+ return m_boxTransform;
+ }
Have any feedback or feature suggestions? Share it here.
This was referenced Oct 9, 2026
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Cpp-linter Review
Used clang-format v21.1.8
Click here for the full clang-format patch
diff --git a/trinity/Eve/Volume/EveBoxVolume.h b/trinity/Eve/Volume/EveBoxVolume.h
index 4790083..6073bb1 100644
--- a/trinity/Eve/Volume/EveBoxVolume.h
+++ b/trinity/Eve/Volume/EveBoxVolume.h
@@ -40 +40,4 @@ public:
- const Matrix& GetBoxTransform() const { return m_boxTransform; }
+ const Matrix& GetBoxTransform() const
+ {
+ return m_boxTransform;
+ }
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The header does not compile, and re-registration can publish stale volume state.
1 open finding
What changed in this PR
Adds EveVolumeObject to publish box-volume transforms to scene consumers.
Changes:
- Adds volume placement, lifecycle handling, and debug rendering.
- Exposes
EveBoxVolumetransforms. - Registers new sources with CMake.
| File | Description |
|---|---|
trinity/Eve/Volume/EveBoxVolume.h |
Exposes the box transform. |
trinity/Eve/EveVolumeObject.h |
Declares the new scene object. |
trinity/Eve/EveVolumeObject.cpp |
Implements volume publishing and lifecycle behavior. |
trinity/Eve/EveVolumeObject_Blue.cpp |
Exposes properties to Blue. |
trinity/CMakeLists.txt |
Adds the new sources. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
phevosccp
force-pushed
the
volume-object
branch
from
October 14, 2026 13:14
eb69d59 to
dde018f
Compare
filipppavlov
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR created the
EveVolumeObject, a standalone object that places a box volume in the scene and passes its world transform to anITr2BoxVolumeconsumer attached in the scene file. It works likeEveTriggerVolumewithout the callback, and has no knowledge of what the consumer does with the shape.Depends on
ITr2BoxVolumefrom carbon-trinityaudioapi carbonengine/trinityaudioapi#7Disclaimer
Since
EveVolumeObjectandEveTriggerVolumeshare their placement and bounds code, it probably makes sense in a follow-up PR to move that into a common base class that both inherit from, so we avoid the duplicate code.Changes
EveVolumeObjectReregisterEntitiesEveBoxVolume::GetBoxTransform()accessorTesting
Tested locally end-to-end with carbon-audio , was able to place rooms and see them in the wwise profiler.