Skip to content

fix(telemetry): document the opt-out for both collectors - #651

Open
Andrei Kvapil (kvaps) wants to merge 2 commits into
mainfrom
fix/telemetry-optout-covers-both-collectors
Open

fix(telemetry): document the opt-out for both collectors#651
Andrei Kvapil (kvaps) wants to merge 2 commits into
mainfrom
fix/telemetry-optout-covers-both-collectors

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Aug 12, 2026

Copy link
Copy Markdown
Member

What this PR does

The telemetry page names two collectors — cozystack-operator and cozystack-controller — and then gives a single opt-out that only reaches the operator. cozystack-controller is deployed by the platform, not by the cozy-installer chart, so --set cozystackOperator.disableTelemetry=true never reaches it: a reader who follows the documented procedure keeps reporting cozy_application_count every 15 minutes, with nothing to indicate the opt-out was partial.

Both steps are now documented:

  • next uses the platform's new telemetry.disabled key.
  • v1.6 has no such key, so it overrides the cozystack-controller component values on the cozystack.cozystack-engine Package directly.

Earlier documentation versions carry the same incomplete instruction. They are left alone here, on the usual "backport only if it matters for a released version" rule — say the word if v1.5 and below should get the workaround too.

Summary by CodeRabbit

  • Documentation
    • Clarified that telemetry is sent by separate operator and controller components.
    • Added instructions for disabling telemetry independently for each component.
    • Documented how to re-enable telemetry for both components across supported documentation versions.

The page names two telemetry collectors, cozystack-operator and
cozystack-controller, and then gave a single opt-out that only reaches the
operator. cozystack-controller is deployed by the platform, not by the
cozy-installer chart, so it kept reporting application counts after a reader
had followed the documented procedure.

Both steps are now given. On next, the second step uses the platform's new
telemetry.disabled key; on v1.6, which has no such key, it overrides the
component values directly.

Assisted-By: Claude
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@netlify

netlify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Deploy Preview for cozystack ready!

Name Link
🔨 Latest commit 254b0e3
🔍 Latest deploy log https://app.netlify.com/projects/cozystack/deploys/6a7cde156917230008e202d5
😎 Deploy Preview https://deploy-preview-651--cozystack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The telemetry documentation for the next, v1.5, and v1.6 versions now explains separate operator and controller telemetry settings. It adds controller opt-out configuration through the cozystack.cozystack-engine Package.

Changes

Telemetry documentation

Layer / File(s) Summary
Separate telemetry sources and operator setting
content/en/docs/next/operations/configuration/telemetry.md, content/en/docs/v1.5/operations/configuration/telemetry.md, content/en/docs/v1.6/operations/configuration/telemetry.md
The opt-out sections identify separate operator and controller telemetry sources and document the operator-specific setting.
Controller configuration and re-enable steps
content/en/docs/next/operations/configuration/telemetry.md, content/en/docs/v1.5/operations/configuration/telemetry.md, content/en/docs/v1.6/operations/configuration/telemetry.md
The pages add cozysty.cozystack-engine Package configuration for cozystackController.disableTelemetry and document re-enabling both components.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: myasnikovdaniil, lllamnyp

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: documenting telemetry opt-out instructions for both collectors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/telemetry-optout-covers-both-collectors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

v1.5 is still installed and carries the same incomplete instruction. It gets
the v1.6 form, which overrides the component values directly, since neither
version has the platform-level telemetry.disabled key.

Earlier documentation versions are left alone.

Assisted-By: Claude
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@content/en/docs/next/operations/configuration/telemetry.md`:
- Around line 102-103: Update the re-enable instructions in
content/en/docs/next/operations/configuration/telemetry.md:102-103 to explicitly
run Helm with cozystackOperator.disableTelemetry=false, then set
telemetry.disabled: false in the Platform Package and apply it. Apply the
corresponding update in
content/en/docs/v1.5/operations/configuration/telemetry.md:103-104 and
content/en/docs/v1.6/operations/configuration/telemetry.md:103-104, using
cozystackController.disableTelemetry: false in the engine Package and
instructing the operator to apply it.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e3816bd-262c-413c-8c09-cb78e0664ea6

📥 Commits

Reviewing files that changed from the base of the PR and between 1e21c76 and 254b0e3.

📒 Files selected for processing (3)
  • content/en/docs/next/operations/configuration/telemetry.md
  • content/en/docs/v1.5/operations/configuration/telemetry.md
  • content/en/docs/v1.6/operations/configuration/telemetry.md

Comment on lines +102 to +103
To re-enable telemetry later, run the same command with
`disableTelemetry=false` and set `telemetry.disabled: false`.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Document separate re-enable actions for the operator and controller.

Each page uses two configuration mechanisms, but the re-enable text can lead users to run only the Helm command and omit the Package update.

  • content/en/docs/next/operations/configuration/telemetry.md#L102-L103: run Helm with cozystackOperator.disableTelemetry=false, then set telemetry.disabled: false in the Platform Package and apply it.
  • content/en/docs/v1.5/operations/configuration/telemetry.md#L103-L104: run Helm with cozystackOperator.disableTelemetry=false, then set cozystackController.disableTelemetry: false in the engine Package and apply it.
  • content/en/docs/v1.6/operations/configuration/telemetry.md#L103-L104: run Helm with cozystackOperator.disableTelemetry=false, then set cozystackController.disableTelemetry: false in the engine Package and apply it.
📍 Affects 3 files
  • content/en/docs/next/operations/configuration/telemetry.md#L102-L103 (this comment)
  • content/en/docs/v1.5/operations/configuration/telemetry.md#L103-L104
  • content/en/docs/v1.6/operations/configuration/telemetry.md#L103-L104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@content/en/docs/next/operations/configuration/telemetry.md` around lines 102
- 103, Update the re-enable instructions in
content/en/docs/next/operations/configuration/telemetry.md:102-103 to explicitly
run Helm with cozystackOperator.disableTelemetry=false, then set
telemetry.disabled: false in the Platform Package and apply it. Apply the
corresponding update in
content/en/docs/v1.5/operations/configuration/telemetry.md:103-104 and
content/en/docs/v1.6/operations/configuration/telemetry.md:103-104, using
cozystackController.disableTelemetry: false in the engine Package and
instructing the operator to apply it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant