Repository navigation
Conversation
The app opens the approval page for a device, and an unsigned-in visitor was sent to the log. Send that page through GitHub so they return and approve the device. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app opens /mobile/authorize to approve a device. A guest was sent to the log and had to find Sign in. They now go straight to GitHub and return to that page to approve the device.
Changes
Guests on the approval page are redirected to GitHub. The approval URL is remembered, so they come back after signing in. A new account finishes onboarding first. Other signed-out pages still open the log, including this one locally, where sign-in is the username modal.
Original report: NativePHP/dev-null-app#52