fix: send guests approving the app to GitHub

KNOWLEDGE_BASE.md

@@ -462,7 +462,7 @@ Sources: [API routes](routes/api.php), [API controllers](app/Http/Controllers/Ap
 
 ### Signed API and devices
 
-An app can use the same `/api/v1` for you with signed requests. It keeps an SSH key on the device and signs every request with it; there are no passwords or API tokens. To sign in, the app opens `/mobile/authorize` on the web: sign in with GitHub if needed, check the key's fingerprint, and approve it. The key then becomes one of your devices, and it does not need to be on your GitHub account. A key that is only on GitHub, such as a GitHub Actions key, cannot use the signed API.
+An app can use the same `/api/v1` for you with signed requests. It keeps an SSH key on the device and signs every request with it; there are no passwords or API tokens. To sign in, the app opens `/mobile/authorize` on the web. A guest goes straight to GitHub and returns to that page; someone already signed in checks the key's fingerprint and approves it. The key then becomes one of your devices, and it does not need to be on your GitHub account. A key that is only on GitHub, such as a GitHub Actions key, cannot use the signed API.
 
 A signed request sees what the web shows you, such as your own pending commits. It can also, with the web's validation, moderation, and rate limits:
 

bootstrap/app.php

@@ -43,7 +43,11 @@
 
         $middleware->encryptCookies(except: ['appearance', 'sidebar_state', 'who_to_follow', 'who_to_follow_round', 'lane_dimming', 'replies_per_page']);
 
-        $middleware->redirectGuestsTo(fn (): string => route('home'));
+        // Approving the app is the one page a guest should leave for GitHub, then return to. Every other page
+        // they open while signed out stays the log. Locally, sign-in is the modal on that log.
+        $middleware->redirectGuestsTo(fn (Request $request): string => $request->routeIs('mobile-authorization.show') && ! app()->isLocal()
+            ? route('login')
+            : route('home'));
         $middleware->redirectUsersTo(fn (Request $request): string => route('log.show', $request->user()->log ?? Log::Following));
 
         // Rate limits apply to the user authenticated by their SSH signature...

tests/Feature/Controllers/MobileAuthorizationControllerTest.php

@@ -51,7 +51,7 @@
     Queue::fake();
     fakeGitHubSponsorsListing();
 
-    $this->get(route('mobile-authorization.show', $this->parameters))->assertRedirectToRoute('home');
+    $this->get(route('mobile-authorization.show', $this->parameters))->assertRedirectToRoute('login');
 
     $user = User::factory()->create(['github_id' => '583231']);